netdev - Re: [PATCH net-next] samples/bpf: Fix map interation in xdp1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166620242101.8250.6135773803189204405.git-patchwork-notify@kernel.org>
Date:   Wed, 19 Oct 2022 18:00:21 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Gerhard Engleder <gerhard@...leder-embedded.com>
Cc:     ast@...nel.org, daniel@...earbox.net, davem@...emloft.net,
        kuba@...nel.org, hawk@...nel.org, john.fastabend@...il.com,
        bpf@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] samples/bpf: Fix map interation in xdp1_user

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@...nel.org>:

On Thu, 13 Oct 2022 22:09:22 +0200 you wrote:
> BPF map iteration in xdp1_user results in endless loop without any
> output, because the return value of bpf_map_get_next_key() is checked
> against the wrong value.
> 
> Other call locations of bpf_map_get_next_key() check for equal 0 for
> continuing the iteration. xdp1_user checks against unequal -1. This is
> wrong for a function which can return arbitrary negative errno values,
> because a return value of e.g. -2 results in an endless loop.
> 
> [...]

Here is the summary with links:
  - [net-next] samples/bpf: Fix map interation in xdp1_user
    https://git.kernel.org/bpf/bpf-next/c/05ee658c654b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html