netdev - Re: [PATCH net-next v3 2/5] ptp: ocp: add Orolia timecard support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b9a3744-0d07-3dca-856e-82810d2ab67c@novek.ru>
Date:   Wed, 19 Oct 2022 19:10:04 +0100
From:   Vadim Fedorenko <vfedorenko@...ek.ru>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Richard Cochran <richardcochran@...il.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        netdev@...r.kernel.org, Vadim Fedorenko <vadfed@...com>,
        Charles Parent <charles.parent@...lia2s.com>
Subject: Re: [PATCH net-next v3 2/5] ptp: ocp: add Orolia timecard support

On 19.10.2022 03:47, Jakub Kicinski wrote:
> On Tue, 18 Oct 2022 12:01:19 +0300 Vadim Fedorenko wrote:
>> From: Vadim Fedorenko <vadfed@...com>
>>
>> This brings in the Orolia timecard support from the GitHub repository.
>> The card uses different drivers to provide access to i2c EEPROM and
>> firmware SPI flash. And it also has a bit different EEPROM map, but
>> other parts of the code are the same and could be reused.
> 
>> +static const struct ocp_attr_group art_timecard_groups[];
>> +static const struct ocp_sma_op ocp_art_sma_op;
> 
> Clang is not on board:
> 
> drivers/ptp/ptp_ocp.c:384:32: warning: tentative definition of variable with internal linkage has incomplete non-array type 'const struct ocp_sma_op' [-Wtentative-definition-incomplete-type]
> static const struct ocp_sma_op ocp_art_sma_op;
>                                 ^
> drivers/ptp/ptp_ocp.c:349:15: note: forward declaration of 'struct ocp_sma_op'
>          const struct ocp_sma_op *sma_op;
>                       ^
> 
> You may need to throw an extern in there.
> 
> Is it not possible to just order things correctly in the first place?
> Is there a dependency cycle?

Ok, haven't tested it with clang before, but now I'm able to reproduce.
I found the way to reorder things, v4 is coming.