netdev - Re: [PATCH v3 net-next 1/3] netlink: add support for formatted extack messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221019130542.3879a64c@kernel.org>
Date:   Wed, 19 Oct 2022 13:05:42 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     <edward.cree@....com>
Cc:     <netdev@...r.kernel.org>, <linux-net-drivers@....com>,
        <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
        <habetsm.xilinx@...il.com>, <johannes@...solutions.net>,
        <marcelo.leitner@...il.com>, <jiri@...nulli.us>,
        Edward Cree <ecree.xilinx@...il.com>
Subject: Re: [PATCH v3 net-next 1/3] netlink: add support for formatted
 extack messages

On Tue, 18 Oct 2022 15:37:27 +0100 edward.cree@....com wrote:
> Include an 80-byte buffer in struct netlink_ext_ack that can be used
>  for scnprintf()ed messages.  This does mean that the resulting string
>  can't be enumerated, translated etc. in the way NL_SET_ERR_MSG() was
>  designed to allow.

I only read the code not the message yesterday, but FWIW I think 
the translation problem is surmountable within the format string 
itself. But let's worry about that if someone actually comes forward
and wants to work on the translations :/