netdev - Re: [PATCH net-next 01/13] genetlink: refactor the cmd <> policy mapping dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d29c7980-7a7e-3a75-3e54-ce081ffdb8cd@intel.com>
Date:   Wed, 19 Oct 2022 14:20:00 -0700
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Johannes Berg <johannes@...solutions.net>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <edumazet@...gle.com>, <pabeni@...hat.com>, <jiri@...nulli.us>,
        <razor@...ckwall.org>, <nicolas.dichtel@...nd.com>,
        <gnault@...hat.com>, <fw@...len.de>
Subject: Re: [PATCH net-next 01/13] genetlink: refactor the cmd <> policy
 mapping dump



On 10/19/2022 8:59 AM, Jakub Kicinski wrote:
> On Wed, 19 Oct 2022 09:50:16 +0200 Johannes Berg wrote:
>>> +			if (ctrl_dumppolicy_put_op(skb, cb, &op))
>>> +				return skb->len;
>>> +
>>> +			ctx->opidx = genl_get_cmd_cnt(ctx->rt);  
>>
>> This (now without a comment that you removed rather than changed), still
>> strikes me as odd.
>>
>> I guess if we add a comment /* don't enter the loop below */ that'd be
>> nicer, but I feel maybe putting the loop into the else instead would be
>> nicer?
> 
> The comment got eaten in rebases, it comes back in patch 10 apparently..
> I'll put it back in v2.

Thanks, I had the same confusion when reviewing.

-Jake