netdev - Re: [PATCH net-next 07/13] genetlink: support split policies in ctrl_dumppolicy_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221019144630.6c71aa5a@kernel.org>
Date:   Wed, 19 Oct 2022 14:46:30 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     <davem@...emloft.net>, <johannes@...solutions.net>,
        <netdev@...r.kernel.org>, <edumazet@...gle.com>,
        <pabeni@...hat.com>, <jiri@...nulli.us>, <razor@...ckwall.org>,
        <nicolas.dichtel@...nd.com>, <gnault@...hat.com>, <fw@...len.de>
Subject: Re: [PATCH net-next 07/13] genetlink: support split policies in
 ctrl_dumppolicy_put_op()

On Wed, 19 Oct 2022 14:38:41 -0700 Jacob Keller wrote:
> > +	if (!doit->policy && !dumpit->policy)
> >  		return 0;
> >    
> 
> We don't need to check the GENL_DONT_VALIDATE_DUMP because the previous
> code for getting the split op checked this and set some other fields, right?

Yes - let me amend the commit message.