netdev - Re: [PATCH] maketable: clean up resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221020093627.2621638-1-gaoxingwang1@huawei.com>
Date:   Thu, 20 Oct 2022 17:36:27 +0800
From:   gaoxingwang <gaoxingwang1@...wei.com>
To:     <stephen@...workplumber.org>
CC:     <dsahern@...il.com>, <gaoxingwang1@...wei.com>,
        <gnault@...hat.com>, <liaichun@...wei.com>,
        <netdev@...r.kernel.org>, <yanan@...wei.com>
Subject: Re: [PATCH] maketable: clean up resources

On Mon, 17 Oct 2022 20:29:14 -0700	[thread overview]

>On Wed, 12 Oct 2022 17:35:34 +0800
>gaoxingwang <gaoxingwang1@...wei.com> wrote:
>
>> Signed-off-by: gaoxingwang <gaoxingwang1@...wei.com>
>> ---
>>  netem/maketable.c | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/netem/maketable.c b/netem/maketable.c
>> index ccb8f0c6..f91ce221 100644
>> --- a/netem/maketable.c
>> +++ b/netem/maketable.c
>> @@ -230,5 +230,8 @@ main(int argc, char **argv)
>>  	inverse = inverttable(table, TABLESIZE, DISTTABLESIZE, total);
>>  	interpolatetable(inverse, TABLESIZE);
>>  	printtable(inverse, TABLESIZE);
>> +	free(table);
>> +	free(inverse)
>> +	close(fp);
>>  	return 0;
>>  }
>
>Why bother. This is a tool only used during builds and this the end
>of the main program so all resources will disappear after return.

I found this issue because a white box scan of the code. Maybe fixing this will save us from the effort to explain it.