netdev - Re: [net 02/16] net/mlx5: Wait for firmware to enable CRS before pci_restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5cf6d7cbb2824f03fcfee2f60e21c4eddf732320.camel@redhat.com>
Date:   Thu, 20 Oct 2022 12:01:51 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Saeed Mahameed <saeed@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Moshe Shemesh <moshe@...dia.com>
Subject: Re: [net 02/16] net/mlx5: Wait for firmware to enable CRS before
 pci_restore_state

Hello,

On Tue, 2022-10-18 at 23:37 -0700, Saeed Mahameed wrote:
> From: Moshe Shemesh <moshe@...dia.com>
> 
> After firmware reset driver should verify firmware already enabled CRS
> and became responsive to pci config cycles before restoring pci state.
> Fix that by waiting till device_id is readable through PCI again.
> 
> Fixes: eabe8e5e88f5 ("net/mlx5: Handle sync reset now event")
> Signed-off-by: Moshe Shemesh <moshe@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>

@Saeed: in the PR, this commit is missing your SoB:

https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git/commit/?h=mlx5-fixes-2022-10-14&id=e63eae9bf56d005a79ee5f8aca0aea757e208598

Could you update the PR?

Thanks!

Paolo