[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <495eb398-bec4-5d68-ef5d-4f02d0122a7c@amd.com>
Date: Thu, 20 Oct 2022 12:39:46 +0200
From: Michal Simek <michal.simek@....com>
To: Andy Chiu <andy.chiu@...ive.com>, <davem@...emloft.net>,
<kuba@...nel.org>, <michal.simek@...inx.com>,
<radhey.shyam.pandey@...inx.com>
CC: <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<krzysztof.kozlowski+dt@...aro.org>, <robh+dt@...nel.org>,
<pabeni@...hat.com>, <edumazet@...gle.com>,
<greentime.hu@...ive.com>
Subject: Re: [PATCH net-next 2/2] dt-bindings: add mdio frequency description
On 10/20/22 11:41, Andy Chiu wrote:
> CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.
>
>
> Add a property to set mdio bus frequency at runtime by DT.
>
> Signed-off-by: Andy Chiu <andy.chiu@...ive.com>
> Reviewed-by: Greentime Hu <greentime.hu@...ive.com>
> ---
> Documentation/devicetree/bindings/net/xilinx_axienet.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/xilinx_axienet.txt b/Documentation/devicetree/bindings/net/xilinx_axienet.txt
> index 1aa4c6006cd0..d78cf402aa2a 100644
> --- a/Documentation/devicetree/bindings/net/xilinx_axienet.txt
> +++ b/Documentation/devicetree/bindings/net/xilinx_axienet.txt
> @@ -43,6 +43,9 @@ Optional properties:
> support both 1000BaseX and SGMII modes. If set, the phy-mode
> should be set to match the mode selected on core reset (i.e.
> by the basex_or_sgmii core input line).
> +- xlnx,mdio-freq: Define the clock frequency of the MDIO bus. If the property
> + does not pressent on the DT, then the mdio driver would use
> + the default 2.5 MHz clock, as mentioned on 802.3 spc.
Isn't it better to specify it based on ccf description. It means &clk and used
clock framework to find value?
Thanks,
Michal
Powered by blists - more mailing lists