netdev - Re: [PATCH for-6.1 1/2] io_uring/net: fail zc send for unsupported protocols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <83044495-2ac1-859f-42b2-4be358541fe2@samba.org>
Date:   Thu, 20 Oct 2022 15:05:04 +0200
From:   Stefan Metzmacher <metze@...ba.org>
To:     Pavel Begunkov <asml.silence@...il.com>, io-uring@...r.kernel.org
Cc:     Jens Axboe <axboe@...nel.dk>, netdev@...r.kernel.org
Subject: Re: [PATCH for-6.1 1/2] io_uring/net: fail zc send for unsupported
 protocols

Hi Pavel,

>> Maybe the socket creation code could set
>> unsigned char skc_so_zerocopy_supported:1;
>> and/or
>> unsigned char skc_zerocopy_msg_ubuf_supported:1;
>>
>> In order to avoid the manual complex tests.
>>
>> What do you think?
> 
> Ok, wanted to do it rather later but let me to try fiddle with it.

Thanks!

> btw, what's happening with smbdirect? Do you plan upstream it one day
> and it's just maturing out of tree?

Yes, once its stable and useful. My current plan (as time permits) is
this:

1. get the samba_io_uring_ev tevent backend working (with current kernels),
    see my other recent mail on that.
2. add OP_SENDMSG[_ZC]/OP_RECVMSG and OP_SPLICE support for the file server
    part of Samba ready (based on 1.)
3. try to get a stripped down version of the smbdirect module ready to be used
    in cifs.ko (without exporting smbdirect sockets to userspace) upstream
4. extend the smbdirect module to be able to be used by ksmbd upstreamed
5. get the uapi for MSG_OOB and msg_control stable for samba's client and server
    into a useful state and then export AF_SMBDIRECT exported to userspace

I hope to get 1 and 2 ready in the next weeks...

metze