netdev - Re: [PATCH net] MAINTAINERS: add keyword match on PTP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1DmxBUCOYpWn5GY@unreal>
Date:   Thu, 20 Oct 2022 09:12:20 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, richardcochran@...il.com
Subject: Re: [PATCH net] MAINTAINERS: add keyword match on PTP

On Thu, Oct 20, 2022 at 08:51:46AM +0300, Leon Romanovsky wrote:
> On Wed, Oct 19, 2022 at 07:19:13PM -0700, Jakub Kicinski wrote:
> > Most of PTP drivers live under ethernet and we have to keep
> > telling people to CC the PTP maintainers. Let's try a keyword
> > match, we can refine as we go if it causes false positives.
> > 
> > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> > ---
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 5c6ce094e55e..ba8ed738494f 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -16673,6 +16673,7 @@ F:	Documentation/driver-api/ptp.rst
> >  F:	drivers/net/phy/dp83640*
> >  F:	drivers/ptp/*
> >  F:	include/linux/ptp_cl*
> > +K:	(?:\b|_)ptp(?:\b|_)
> 
> I tried it with grep (maybe it is wrong) and it finds only files with
> underscores.
> 
> ➜  kernel git:(m/xfrm-latest) tree | grep -E "(?:\b|_)ptp(?:\b|_)"
> │   │   │   │   │   ├── ice_ptp_consts.h
> │   │   │   │   │   ├── ice_ptp_hw.c
> │   │   │   │   │   ├── ice_ptp_hw.h
> 
> And this is as it is written in MAINTAINERS without "_".
> 
> ➜  kernel git:(m/xfrm-latest) tree | grep -E "\bptp\b"
> │   │       ├── sysfs-ptp
> │   │   │   │   ├── intel,ixp46x-ptp-timer.yaml
> │   │   │   ├── ptp
> │   │   │   │   ├── brcm,ptp-dte.txt
> │   │   │   │   ├── ptp-idt82p33.yaml
> │   │   │   │   ├── ptp-idtcm.yaml
> │   │   │   │   ├── ptp-ines.txt
> │   │   │   │   ├── ptp-qoriq.txt
> │   │   ├── ptp.rst
> │   │   │   │   ├── ptp.c
> │   │   │   │   ├── ptp.h
> │   │   │   │       └── xgbe-ptp.c
> │   │   │   │   │   ├── dpaa2-ptp.c
> │   │   │   │   │   ├── dpaa2-ptp.h
> │   │   │   │   │   ├── ptp.c
> │   │   │   │   │   │   ├── ptp.c
> │   │   │   │   │   │   ├── ptp.h
> │   │   │   │   │       │   ├── ptp.c
> │   │   │   │   │       │   ├── ptp.h
> │   │   │   │   ├── ptp.c
> │   │   │   │   ├── ptp.h
> │   │   │   │   │   ├── ptp.c
> │   │   │   │   │   ├── ptp.h
> │   │   │   ├── bcm-phy-ptp.c
> 
> Should I try it differently?

And maybe "K: ptp" will be even better.

> 
> Thanks
> 
> >  
> >  PTP VIRTUAL CLOCK SUPPORT
> >  M:	Yangbo Lu <yangbo.lu@....com>
> > -- 
> > 2.37.3
> >