netdev - Re: [PATCH net-next v2 4/9] net: microchip: sparx5: Adding initial tc flower support for VCAP API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221020073134.ru2p5m5ittadthzr@wse-c0155>
Date:   Thu, 20 Oct 2022 09:31:34 +0200
From:   Casper Andersson <casper.casan@...il.com>
To:     Steen Hegelund <steen.hegelund@...rochip.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, UNGLinuxDriver@...rochip.com,
        Randy Dunlap <rdunlap@...radead.org>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Wan Jiabing <wanjiabing@...o.com>,
        Nathan Huckleberry <nhuck@...gle.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next v2 4/9] net: microchip: sparx5: Adding initial
 tc flower support for VCAP API

Hi Steen,

It's a pretty big patch series, but overall I think it looks very good.
I've got some minor comments. I also tested it on the Microchip PCB135
switch and it works as described.

On 2022-10-19 13:42, Steen Hegelund wrote:
> +static void sparx5_tc_flower_set_exterr(struct net_device *ndev,
> +					struct flow_cls_offload *fco,
> +					struct vcap_rule *vrule)
> +{
> +	switch (vrule->exterr) {
> +	case VCAP_ERR_NONE:
> +		break;
> +	case VCAP_ERR_NO_ADMIN:
> +		NL_SET_ERR_MSG_MOD(fco->common.extack,
> +				   "Missing VCAP instance");
> +		break;
> +	case VCAP_ERR_NO_NETDEV:
> +		NL_SET_ERR_MSG_MOD(fco->common.extack,
> +				   "Missing network interface");
> +		break;
> +	case VCAP_ERR_NO_KEYSET_MATCH:
> +		NL_SET_ERR_MSG_MOD(fco->common.extack,
> +				   "No keyset matched the filter keys");
> +		break;
> +	case VCAP_ERR_NO_ACTIONSET_MATCH:
> +		NL_SET_ERR_MSG_MOD(fco->common.extack,
> +				   "No actionset matched the filter actions");
> +		break;
> +	case VCAP_ERR_NO_PORT_KEYSET_MATCH:
> +		NL_SET_ERR_MSG_MOD(fco->common.extack,
> +				   "No port keyset matched the filter keys");
> +		break;
> +	}
> +}

Could this also be shared in the VCAP API? It currently doesn't use
anything Sparx5 specific. Though, net_device is unused so I'm guessing
you might have plans for this in the future. And it might fit better
here according to your design goals.

Tested-by: Casper Andersson <casper.casan@...il.com>
Reviewed-by: Casper Andersson <casper.casan@...il.com>