netdev - Re: [PATCH net] atlantic: fix deadlock at aq_nic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Oct 2022 09:46:45 +0200
From:   Íñigo Huguet <ihuguet@...hat.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Andrew Lunn <andrew@...n.ch>, irusskikh@...vell.com,
        dbogdanov@...vell.com, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, netdev@...r.kernel.org,
        Li Liang <liali@...hat.com>
Subject: Re: [PATCH net] atlantic: fix deadlock at aq_nic_stop

On Wed, Oct 19, 2022 at 5:39 PM Jakub Kicinski <kuba@...nel.org> wrote:
> Dunno, locks don't protect operations, they protect state (as the link
> Andrew sent probably explains?),

Yes, you're completely right. I understood that well, and Andrew's
link (which is very good, thanks Andrew) explains it too. I wrongly
said "operations" because in this case the lock/unlock must be done
mainly inside the macsec_ops (operations), and thus my confusion.

I'm about to send my patch. If you still feel that it's not the best
solution, feel free to insist on the refcount or any other approach
you think is better.

Thanks and sorry for the noise
-- 
Íñigo Huguet