netdev - Re: [PATCH net] net: hns: fix possible memory leak in hnae_ae

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e9539a9-e3b9-1418-cd3b-426d2efeaef1@huawei.com>
Date:   Thu, 20 Oct 2022 15:48:38 +0800
From:   Yang Yingliang <yangyingliang@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>, Leon Romanovsky <leon@...nel.org>
CC:     <netdev@...r.kernel.org>, <yisen.zhuang@...wei.com>,
        <salil.mehta@...wei.com>, <davem@...emloft.net>
Subject: Re: [PATCH net] net: hns: fix possible memory leak in
 hnae_ae_register()


On 2022/10/20 8:28, Jakub Kicinski wrote:
> On Tue, 18 Oct 2022 15:58:38 +0300 Leon Romanovsky wrote:
>> The change itself is ok.
> Also the .release function is empty which is another bad smell?
The upper device (struct dsaf_device *dsaf_dev) is allocated by 
devm_kzalloc(),
so it's no need to free it in ->release().

Thanks,
Yang
>
>> Reviewed-by: Leon Romanovsky <leonro@...dia.com>
> Thanks!
> .