netdev - RE: [PATCH RFC 3/3] net: renesas: rswitch: Pass host parameters to phydev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYBPR01MB53417E452421A54E73F8C965D82A9@TYBPR01MB5341.jpnprd01.prod.outlook.com>
Date:   Thu, 20 Oct 2022 00:40:14 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Marek Behún <kabel@...nel.org>
CC:     "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH RFC 3/3] net: renesas: rswitch: Pass host parameters to
 phydev

Hi Marek,

> From: Marek Behún, Sent: Wednesday, October 19, 2022 7:41 PM
> 
> On Wed, 19 Oct 2022 17:50:52 +0900
> Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com> wrote:
> 
> > Use of_phy_connect_with_host_params() to pass host parameters to
> > phydev. Otherwise, connected PHY cannot work correctly.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> > ---
> >  drivers/net/ethernet/renesas/rswitch.c | 13 +++++++++++--
> >  1 file changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
> > index c604331bfd88..bb2f1e667210 100644
> > --- a/drivers/net/ethernet/renesas/rswitch.c
> > +++ b/drivers/net/ethernet/renesas/rswitch.c
> > @@ -16,6 +16,7 @@
> >  #include <linux/of_irq.h>
> >  #include <linux/of_mdio.h>
> >  #include <linux/of_net.h>
> > +#include <linux/phy.h>
> >  #include <linux/phy/phy.h>
> >  #include <linux/pm_runtime.h>
> >  #include <linux/slab.h>
> > @@ -1234,11 +1235,19 @@ static void rswitch_phy_remove_link_mode(struct rswitch_device *rdev,
> >
> >  static int rswitch_phy_init(struct rswitch_device *rdev, struct device_node *phy)
> >  {
> > +	DECLARE_PHY_INTERFACE_MASK(host_interfaces);
> >  	struct phy_device *phydev;
> >  	int err = 0;
> >
> > -	phydev = of_phy_connect(rdev->ndev, phy, rswitch_adjust_link, 0,
> > -				rdev->etha->phy_interface);
> > +	phy_interface_zero(host_interfaces);
> > +	if (rdev->etha->phy_interface == PHY_INTERFACE_MODE_SGMII)
> > +		__set_bit(PHY_INTERFACE_MODE_SGMII, host_interfaces);
> > +
> > +	phydev = of_phy_connect_with_host_params(rdev->ndev, phy,
> > +						 rswitch_adjust_link, 0,
> > +						 rdev->etha->phy_interface,
> > +						 host_interfaces,
> > +						 rdev->etha->speed);
> >  	if (!phydev) {
> >  		err = -ENOENT;
> >  		goto out;
> 
> NAK. There already is API for doing this: phylink. Adding new, and so
> much specific function for this is a waste. Just convert the rswitch
> driver to phylink.
> 
> Please look at the documentation at
>   Documentation/networking/sfp-phylink.rst

Thank you for your comments! I'll try to convert the rswitch driver to phylink.

Best regards,
Yoshihiro Shimoda

> Marek