lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <xhsmhlep9wa8i.mognet@vschneid.remote.csb> Date: Fri, 21 Oct 2022 14:57:01 +0100 From: Valentin Schneider <vschneid@...hat.com> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Cc: netdev@...r.kernel.org, linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org, Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Yury Norov <yury.norov@...il.com>, Rasmus Villemoes <linux@...musvillemoes.dk>, Ingo Molnar <mingo@...nel.org>, Peter Zijlstra <peterz@...radead.org>, Vincent Guittot <vincent.guittot@...aro.org>, Dietmar Eggemann <dietmar.eggemann@....com>, Steven Rostedt <rostedt@...dmis.org>, Mel Gorman <mgorman@...e.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Heiko Carstens <hca@...ux.ibm.com>, Tony Luck <tony.luck@...el.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, Gal Pressman <gal@...dia.com>, Tariq Toukan <tariqt@...dia.com>, Jesse Brandeburg <jesse.brandeburg@...el.com> Subject: Re: [PATCH v5 2/3] sched/topology: Introduce for_each_numa_hop_mask() On 21/10/22 16:16, Andy Shevchenko wrote: > On Fri, Oct 21, 2022 at 01:19:26PM +0100, Valentin Schneider wrote: >> The recently introduced sched_numa_hop_mask() exposes cpumasks of CPUs >> reachable within a given distance budget, wrap the logic for iterating over >> all (distance, mask) values inside an iterator macro. > > ... > >> #ifdef CONFIG_NUMA >> -extern const struct cpumask *sched_numa_hop_mask(int node, int hops); >> +extern const struct cpumask *sched_numa_hop_mask(unsigned int node, unsigned int hops); >> #else >> -static inline const struct cpumask *sched_numa_hop_mask(int node, int hops) >> +static inline const struct cpumask * >> +sched_numa_hop_mask(unsigned int node, unsigned int hops) >> { >> - if (node == NUMA_NO_NODE && !hops) >> - return cpu_online_mask; >> - >> return ERR_PTR(-EOPNOTSUPP); >> } >> #endif /* CONFIG_NUMA */ > > I didn't get how the above two changes are related to the 3rd one which > introduces a for_each type of macro. > > If you need change int --> unsigned int, perhaps it can be done in a separate > patch. > > The change inside inliner I dunno about. Not an expert. > That's a rebase fail, this should all be in the first patch, my bad.
Powered by blists - more mailing lists