lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <trinity-e60759de-3f0f-4b1e-bc0f-b33c4f8ac201-1666374467573@3c-app-gmx-bap55> Date: Fri, 21 Oct 2022 19:47:47 +0200 From: Frank Wunderlich <frank-w@...lic-files.de> To: "Russell King (Oracle)" <linux@...linux.org.uk> Cc: Frank Wunderlich <linux@...web.de>, linux-mediatek@...ts.infradead.org, Alexander Couzens <lynxis@...0.eu>, Felix Fietkau <nbd@....name>, John Crispin <john@...ozen.org>, Sean Wang <sean.wang@...iatek.com>, Mark Lee <Mark-MC.Lee@...iatek.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Matthias Brugger <matthias.bgg@...il.com>, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Aw: Re: [PATCH v2] net: mtk_sgmii: implement mtk_pcs_ops > Gesendet: Freitag, 21. Oktober 2022 um 11:06 Uhr > Von: "Russell King (Oracle)" <linux@...linux.org.uk> > An: "Frank Wunderlich" <frank-w@...lic-files.de> > On Fri, Oct 21, 2022 at 08:04:51AM +0200, Frank Wunderlich wrote: > > I have no register documentation to check if there is any way to read out pause/duplex setting. Maybe MTK can answer this or extend function later. > > I suspect we can probably guess. > > Looking at SGMSYS_PCS_CONTROL_1, this is actually the standard BMCR in > the low 16 bits, and BMSR in the upper 16 bits, so: > > At address 4, I'd expect the PHYSID. > At address 8, I'd expect the advertisement register in the low 16 bits > and the link partner advertisement in the upper 16 bits. > > Can you try an experiment, and in mtk_sgmii_init() try accessing the > regmap at address 0, 4, and 8 and print their contents please? is this what you want to see? int mtk_sgmii_init(struct mtk_sgmii *ss, struct device_node *r, u32 ana_rgc3) { struct device_node *np; + unsigned int val; int i; for (i = 0; i < MTK_MAX_DEVS; i++) { @@ -158,6 +159,12 @@ int mtk_sgmii_init(struct mtk_sgmii *ss, struct device_node *r, u32 ana_rgc3) if (IS_ERR(ss->pcs[i].regmap)) return PTR_ERR(ss->pcs[i].regmap); + regmap_read(ss->pcs[i].regmap, SGMSYS_PCS_CONTROL_1, &val); + printk(KERN_ALERT "dev: %d offset:0 0x%x",i,val); + regmap_read(ss->pcs[i].regmap, SGMSYS_PCS_CONTROL_1+4, &val); + printk(KERN_ALERT "dev: %d offset:4 0x%x",i,val); + regmap_read(ss->pcs[i].regmap, SGMSYS_PCS_CONTROL_1+8, &val); + printk(KERN_ALERT "dev: %d offset:8 0x%x",i,val); ss->pcs[i].pcs.ops = &mtk_pcs_ops; } [ 1.083359] dev: 0 offset:0 0x840140 [ 1.083376] dev: 0 offset:4 0x4d544950 [ 1.086955] dev: 0 offset:8 0x1 [ 1.090697] dev: 1 offset:0 0x81140 [ 1.093866] dev: 1 offset:4 0x4d544950 [ 1.097342] dev: 1 offset:8 0x1 > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! > regards Frank
Powered by blists - more mailing lists