netdev - Re: [PATCH v2 net-next 0/2] soreuseport: Fix issues related to the faster selection algorithm.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221021200434.543-1-kuniyu@amazon.com>
Date:   Fri, 21 Oct 2022 13:04:34 -0700
From:   Kuniyuki Iwashima <kuniyu@...zon.com>
To:     <kuniyu@...zon.com>
CC:     <davem@...emloft.net>, <edumazet@...gle.com>,
        <kazuhooku@...il.com>, <kraig@...gle.com>, <kuba@...nel.org>,
        <kuni1840@...il.com>, <martin.lau@...nel.org>,
        <netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH v2 net-next 0/2] soreuseport: Fix issues related to the faster selection algorithm.

From:   Kuniyuki Iwashima <kuniyu@...zon.com>
Date:   Thu, 20 Oct 2022 09:39:52 -0700
> setsockopt(SO_INCOMING_CPU) for UDP/TCP is broken since 4.5/4.6 due to
> these commits:
> 
>   * e32ea7e74727 ("soreuseport: fast reuseport UDP socket selection")
>   * c125e80b8868 ("soreuseport: fast reuseport TCP socket selection")
> 
> These commits introduced the O(1) socket selection algorithm and removed
> O(n) iteration over the list, but it ignores the score calculated by
> compute_score().  As a result, it caused two misbehaviours:
> 
>   * Unconnected sockets receive packets sent to connected sockets
>   * SO_INCOMING_CPU does not work
> 
> The former is fixed by commit acdcecc61285 ("udp: correct reuseport
> selection with connected sockets").  This series fixes the latter and
> adds some tests for SO_INCOMING_CPU.

This cannot be applied on net-next cleanly for now, I'll rebase.