| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20221021224140.GA574155-robh@kernel.org>
Date: Fri, 21 Oct 2022 17:41:40 -0500
From: Rob Herring <robh@...nel.org>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: netdev@...r.kernel.org, nbd@....name, john@...ozen.org,
sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, matthias.bgg@...il.com,
linux-mediatek@...ts.infradead.org, lorenzo.bianconi@...hat.com,
Bo.Jiao@...iatek.com, sujuan.chen@...iatek.com,
ryder.Lee@...iatek.com, evelyn.tsai@...iatek.com,
devicetree@...r.kernel.org, daniel@...rotopia.org
Subject: Re: [PATCH net-next 2/6] dt-bindings: net: mediatek: add WED RX
binding for MT7986 eth driver
On Fri, Oct 21, 2022 at 06:18:32PM +0200, Lorenzo Bianconi wrote:
> Document the binding for the RX Wireless Ethernet Dispatch core on the
> MT7986 ethernet driver used to offload traffic received by WLAN NIC and
> forwarded to LAN/WAN one.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> ---
> .../arm/mediatek/mediatek,mt7622-wed.yaml | 126 ++++++++++++++++++
> .../arm/mediatek/mediatek,mt7986-wo-boot.yaml | 45 +++++++
> .../arm/mediatek/mediatek,mt7986-wo-ccif.yaml | 49 +++++++
> .../arm/mediatek/mediatek,mt7986-wo-dlm.yaml | 66 +++++++++
> 4 files changed, 286 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7986-wo-boot.yaml
> create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7986-wo-ccif.yaml
> create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7986-wo-dlm.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7622-wed.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7622-wed.yaml
> index 84fb0a146b6e..623f11df5545 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7622-wed.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7622-wed.yaml
> @@ -29,6 +29,59 @@ properties:
> interrupts:
> maxItems: 1
>
> + mediatek,wocpu_emi:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> + description:
> + Phandle to a node describing reserved memory used by mtk wed firmware
> + (see bindings/reserved-memory/reserved-memory.txt)
What does that file contain?
There's a standard property to refer to reserved-memory nodes, use it.
> +
> + mediatek,wocpu_data:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> + description:
> + Phandle to a node describing reserved memory used by mtk wed firmware
> + (see bindings/reserved-memory/reserved-memory.txt)
> +
> + mediatek,wocpu_ilm:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> + description:
> + Phandle to a node describing memory used by mtk wed firmware
> +
> + mediatek,ap2woccif:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> + description:
> + Phandle to the mediatek wed-wo controller.
> +
> + mediatek,wocpu_boot:
s/_/-/
> + $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> + description:
> + Phandle to the mediatek wed-wo boot interface.
> +
> + mediatek,wocpu_dlm:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + maxItems: 1
> + description:
> + Phandle to the mediatek wed-wo rx hw ring.
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt7986-wed
> + then:
> + properties:
> + mediatek,wocpu_data: true
> + mediatek,wocpu_boot: true
> + mediatek,wocpu_emi: true
> + mediatek,wocpu_ilm: true
> + mediatek,ap2woccif: true
> + mediatek,wocpu_dlm: true
> +
> required:
> - compatible
> - reg
> @@ -49,3 +102,76 @@ examples:
> interrupts = <GIC_SPI 214 IRQ_TYPE_LEVEL_LOW>;
> };
> };
> +
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/reset/ti-syscon.h>
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + wocpu0_emi: wocpu0_emi@...00000 {
> + reg = <0 0x4fd00000 0 0x40000>;
> + no-map;
> + };
> +
> + wocpu_data: wocpu_data@...80000 {
> + reg = <0 0x4fd80000 0 0x240000>;
> + no-map;
> + };
> + };
> +
> + ethsys: syscon@...00000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "mediatek,mt7986-ethsys", "syscon";
> + reg = <0 0x15000000 0 0x1000>;
> +
> + #clock-cells = <1>;
> + #reset-cells = <1>;
> + ethsysrst: reset-controller {
> + compatible = "ti,syscon-reset";
> + #reset-cells = <1>;
> + ti,reset-bits = <0x34 4 0x34 4 0x34 4 (ASSERT_SET | DEASSERT_CLEAR | STATUS_SET)>;
> + };
You don't need to show providers in examples. Presumably we already have
an example of them in their binding.
> + };
> +
> + wocpu0_ilm: wocpu0_ilm@...e0000 {
> + compatible = "mediatek,wocpu0_ilm";
> + reg = <0 0x151e0000 0 0x8000>;
> + };
> +
> + cpu_boot: wocpu_boot@...94000 {
> + compatible = "mediatek,wocpu_boot", "syscon";
> + reg = <0 0x15194000 0 0x1000>;
> + };
> +
> + ap2woccif0: ap2woccif@...a5000 {
> + compatible = "mediatek,ap2woccif", "syscon";
> + reg = <0 0x151a5000 0 0x1000>;
> + interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> + wocpu0_dlm: wocpu_dlm@...e8000 {
> + compatible = "mediatek,wocpu_dlm";
> + reg = <0 0x151e8000 0 0x2000>;
> + resets = <ðsysrst 0>;
> + reset-names = "wocpu_rst";
> + };
> +
> + wed1: wed@...0a000 {
> + compatible = "mediatek,mt7986-wed","syscon";
> + reg = <0 0x15010000 0 0x1000>;
> + interrupts = <GIC_SPI 205 IRQ_TYPE_LEVEL_HIGH>;
> +
> + mediatek,wocpu_data = <&wocpu_data>;
> + mediatek,ap2woccif = <&ap2woccif0>;
> + mediatek,wocpu_ilm = <&wocpu0_ilm>;
> + mediatek,wocpu_dlm = <&wocpu0_dlm>;
> + mediatek,wocpu_emi = <&wocpu_emi>;
> + mediatek,wocpu_boot = <&cpu_boot>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7986-wo-boot.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7986-wo-boot.yaml
> new file mode 100644
> index 000000000000..dc8fdb706960
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7986-wo-boot.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/arm/mediatek/mediatek,mt7986-wo-boot.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: MediaTek WED WO boot controller interface for MT7986
What is 'WED'?
> +
> +maintainers:
> + - Lorenzo Bianconi <lorenzo@...nel.org>
> + - Felix Fietkau <nbd@....name>
> +
> +description:
> + The mediatek wo-boot provides a configuration interface for WED WO
> + boot controller on MT7986 soc.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - mediatek,wocpu_boot
This needs to be SoC specific.
And s/_/-/
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + cpu_boot: wocpu_boot@...94000 {
> + compatible = "mediatek,wocpu_boot", "syscon";
> + reg = <0 0x15194000 0 0x1000>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7986-wo-ccif.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7986-wo-ccif.yaml
> new file mode 100644
> index 000000000000..8fea86425983
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7986-wo-ccif.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/arm/mediatek/mediatek,mt7986-wo-ccif.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: MediaTek WED WO Controller for MT7986
> +
> +maintainers:
> + - Lorenzo Bianconi <lorenzo@...nel.org>
> + - Felix Fietkau <nbd@....name>
> +
> +description:
> + The mediatek WO-ccif provides a configuration interface for WED WO
> + controller on MT7986 soc.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - mediatek,ap2woccif
SoC specific.
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ap2woccif0: ap2woccif@...a5000 {
> + compatible = "mediatek,ap2woccif", "syscon";
> + reg = <0 0x151a5000 0 0x1000>;
> + interrupts = <GIC_SPI 205 IRQ_TYPE_LEVEL_HIGH>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7986-wo-dlm.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7986-wo-dlm.yaml
> new file mode 100644
> index 000000000000..529343c57e4b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7986-wo-dlm.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/arm/mediatek/mediatek,mt7986-wo-dlm.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: MediaTek WED WO hw rx ring interface for MT7986
> +
> +maintainers:
> + - Lorenzo Bianconi <lorenzo@...nel.org>
> + - Felix Fietkau <nbd@....name>
> +
> +description:
> + The mediatek WO-dlm provides a configuration interface for WED WO
> + rx ring on MT7986 soc.
> +
> +properties:
> + compatible:
> + const: mediatek,wocpu_dlm
Soc specific
s/_/-/
> +
> + reg:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - resets
> + - reset-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/reset/ti-syscon.h>
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + ethsys: syscon@...00000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "mediatek,mt7986-ethsys", "syscon";
> + reg = <0 0x15000000 0 0x1000>;
> +
> + #clock-cells = <1>;
> + #reset-cells = <1>;
> + ethsysrst: reset-controller {
> + compatible = "ti,syscon-reset";
> + #reset-cells = <1>;
> + ti,reset-bits = <0x34 4 0x34 4 0x34 4 (ASSERT_SET | DEASSERT_CLEAR | STATUS_SET)>;
> + };
> + };
Again, don't need the provider here.
> +
> + wocpu0_dlm: wocpu_dlm@...e8000 {
> + compatible = "mediatek,wocpu_dlm";
> + reg = <0 0x151e8000 0 0x2000>;
> + resets = <ðsysrst 0>;
> + reset-names = "wocpu_rst";
> + };
> + };
> --
> 2.37.3
>
>
Powered by blists - more mailing lists