lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 22 Oct 2022 12:21:27 +0200
From:   Greg Kroah-Hartman <>
To:     "Jason A. Donenfeld" <>
Cc:, Kees Cook <>,
        Jakub Kicinski <>,
        Russell King <>,
        Catalin Marinas <>,
        Thomas Bogendoerfer <>,
        Heiko Carstens <>,
        Herbert Xu <>,
        Christoph Böhmwalder 
        Jani Nikula <>,
        Jason Gunthorpe <>,
        Sakari Ailus <>,
        "Martin K . Petersen" <>,
        Theodore Ts'o <>,
        Andreas Dilger <>,
        Jaegeuk Kim <>,
        Richard Weinberger <>,
        "Darrick J . Wong" <>,
        SeongJae Park <>,
        Thomas Gleixner <>,
        Andrew Morton <>,
        Michael Ellerman <>,
        Helge Deller <>,,,,,,,,,,,
Subject: Re: [PATCH v1 0/5] convert tree to

On Fri, Oct 21, 2022 at 09:43:58PM -0400, Jason A. Donenfeld wrote:
> Hey everyone,
> Here's the second and final tranche of tree-wide conversions to get
> random integer handling a bit tamer. It's predominantly another
> Coccinelle-based patchset.
> First we s/prandom_u32_max/get_random_u32_below/, since the former is
> just a deprecated alias for the latter. Then in the next commit we can
> remove prandom_u32_max all together. I'm quite happy about finally being
> able to do that. It means that prandom.h is now only for deterministic and 
> repeatable randomness, not non-deterministic/cryptographic randomness.
> That line is no longer blurred.
> Then, in order to clean up a bunch of inefficient patterns, we introduce
> two trivial static inline helper functions built on top of
> get_random_u32_below: get_random_u32_above and get_random_u32_between.
> These are pretty straight forward to use and understand. Then the final
> two patches convert some gnarly open-coded number juggling to use these
> helpers.
> I've used Coccinelle for all the treewide patches, so hopefully review
> is rather uneventful. I didn't accept all of the changes that Coccinelle
> proposed, though, as these tend to be somewhat context-specific. I erred
> on the side of just going with the most obvious cases, at least this
> time through. And then we can address more complicated cases through
> actual maintainer trees.
> Since get_random_u32_below() sits in my random.git tree, these patches
> too will flow through that same tree.
> Regards,
> Jason

Reviewed-by: Greg Kroah-Hartman <>

Powered by blists - more mailing lists