lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 22 Oct 2022 16:39:37 +0300 From: Vladimir Oltean <olteanv@...il.com> To: Oleksandr Mazur <oleksandr.mazur@...ision.eu> Cc: "netdev@...io-technology.com" <netdev@...io-technology.com>, "davem@...emloft.net" <davem@...emloft.net>, "kuba@...nel.org" <kuba@...nel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Florian Fainelli <f.fainelli@...il.com>, Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Kurt Kanzenbach <kurt@...utronix.de>, Hauke Mehrtens <hauke@...ke-m.de>, Woojung Huh <woojung.huh@...rochip.com>, "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>, Sean Wang <sean.wang@...iatek.com>, Landen Chao <Landen.Chao@...iatek.com>, DENG Qingfang <dqfext@...il.com>, Matthias Brugger <matthias.bgg@...il.com>, Claudiu Manoil <claudiu.manoil@....com>, Alexandre Belloni <alexandre.belloni@...tlin.com>, Jiri Pirko <jiri@...nulli.us>, Ivan Vecera <ivecera@...hat.com>, Roopa Prabhu <roopa@...dia.com>, Nikolay Aleksandrov <razor@...ckwall.org>, Shuah Khan <shuah@...nel.org>, Russell King <linux@...linux.org.uk>, Christian Marangi <ansuelsmth@...il.com>, Daniel Borkmann <daniel@...earbox.net>, Yuwei Wang <wangyuweihx@...il.com>, Petr Machata <petrm@...dia.com>, Ido Schimmel <idosch@...dia.com>, Florent Fourcot <florent.fourcot@...irst.fr>, Hans Schultz <schultz.hans@...il.com>, Joachim Wiberg <troglobit@...il.com>, Amit Cohen <amcohen@...dia.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>, "bridge@...ts.linux-foundation.org" <bridge@...ts.linux-foundation.org>, "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org> Subject: Re: [PATCH v8 net-next 10/12] net: dsa: mv88e6xxx: mac-auth/MAB implementation On Sat, Oct 22, 2022 at 12:55:14PM +0000, Oleksandr Mazur wrote: > > > I hope the following script will exemplify what I mean. > .. > Oh, i get it now. > > Frankly speaking we haven't stumbled across such scenario / issue > before. But i can tell it does indeed seems a bit broken; > > I think there are 2 options here: > 1. The setup itself seems insecure, and user should be aware of such behavior / issue; Be aware, and do what? Port locking is unfit for use if learning is left enabled (in the way learning is currently done). > 2. Bridge indeed should not learn MACs if BR_PORT_LOCKED is set. > E.g. learning condition should be something like: not BR_PORT_locked > and learning is on; Rather than violate the BR_LEARNING flag (have it set but do nothing, which would require even more checks in the fast path), I was proposing to not allow the BR_PORT_LOCKED | BR_LEARNING configuration at all. My question to you was if you're aware of any regression in prestera with such a change. > > I don't understand the last step. Why is the BR_PORT_LOCKED flag disabled? > > If disabled, the port will receive frames with any unknown MAC SA, > > not just the authorized ones. > > Sorry for the confusion. Basically, what i described what i would > expect from a daemon (e.g. daemon would disable LOCKED); So just > ignore that part. But still, why would the daemon disable BR_PORT_LOCKED once a station is authorized? You're describing a sample/test application, not a port security solution...
Powered by blists - more mailing lists