netdev - Re: [PATCH net-next v3 00/12] net: dpaa2-eth: AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r0yy2x0c.fsf@all.your.base.are.belong.to.us>
Date:   Sun, 23 Oct 2022 20:52:19 +0200
From:   Björn Töpel <bjorn@...nel.org>
To:     Ioana Ciornei <ioana.ciornei@....com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>, bpf@...r.kernel.org
Subject: Re: [PATCH net-next v3 00/12] net: dpaa2-eth: AF_XDP zero-copy support

Ioana Ciornei <ioana.ciornei@....com> writes:

> This patch set adds support for AF_XDP zero-copy in the dpaa2-eth
> driver. The support is available on the LX2160A SoC and its variants and
> only on interfaces (DPNIs) with a maximum of 8 queues (HW limitations
> are the root cause).
>
> We are first implementing the .get_channels() callback since this a
> dependency for further work.
>
> Patches 2-3 are working on making the necessary changes for multiple
> buffer pools on a single interface. By default, without an AF_XDP socket
> attached, only a single buffer pool will be used and shared between all
> the queues. The changes in the functions are made in this patch, but the
> actual allocation and setup of a new BP is done in patch#10.
>
> Patches 4-5 are improving the information exposed in debugfs. We are
> exposing a new file to show which buffer pool is used by what channels
> and how many buffers it currently has.
>
> The 6th patch updates the dpni_set_pools() firmware API so that we are
> capable of setting up a different buffer per queue in later patches.
>
> In the 7th patch the generic dev_open/close APIs are used instead of the
> dpaa2-eth internal ones.
>
> Patches 8-9 are rearranging the existing code in dpaa2-eth.c in order to
> create new functions which will be used in the XSK implementation in
> dpaa2-xsk.c
>
> Finally, the last 3 patches are adding the actual support for both the
> Rx and Tx path of AF_XDP zero-copy and some associated tracepoints.
> Details on the implementation can be found in the actual patch.
>
> Changes in v2:
>  - 3/12:  Export dpaa2_eth_allocate_dpbp/dpaa2_eth_free_dpbp in this
>    patch to avoid a build warning. The functions will be used in next
>    patches.
>  - 6/12:  Use __le16 instead of u16 for the dpbp_id field.
>  - 12/12: Use xdp_buff->data_hard_start when tracing the BP seeding.
>
> Changes in v3:
>  - 3/12: fix leaking of bp on error path
>

Again, sorry about the feedback delay.

I don't have access to the hardware, so I mostly glossed over the
patches that didn't touch AF_XDP directly.

The series looks clean, and is easy to follow. The XSK pool usage looks
correct. Awesome to see yet another AF_XDP capable driver!

Feel free to add:
Acked-by: Björn Töpel <bjorn@...nel.org>