lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 23 Oct 2022 21:21:37 +0200 From: Frank Wunderlich <frank-w@...lic-files.de> To: Frank Wunderlich <frank-w@...lic-files.de> Cc: "Russell King (Oracle)" <linux@...linux.org.uk>, Frank Wunderlich <linux@...web.de>, linux-mediatek@...ts.infradead.org, Alexander Couzens <lynxis@...0.eu>, Felix Fietkau <nbd@....name>, John Crispin <john@...ozen.org>, Sean Wang <sean.wang@...iatek.com>, Mark Lee <Mark-MC.Lee@...iatek.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Matthias Brugger <matthias.bgg@...il.com>, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Aw: Re: Re: [PATCH v2] net: mtk_sgmii: implement mtk_pcs_ops > Gesendet: Sonntag, 23. Oktober 2022 um 21:03 Uhr > Von: "Frank Wunderlich" <frank-w@...lic-files.de> > if you fix this typo you can send the patch and add my tested-by: > > regmap_read(mpcs->regmap, SGMSYS_SGMII_MODE, &val); > - if (interface = == PHY_INTERFACE_MODE_SGMII) > + if (interface == PHY_INTERFACE_MODE_SGMII) > val |= SGMII_IF_MODE_BIT0; > else > val &= ~SGMII_IF_MODE_BIT0; > > should i send an update for my patch including this: > > state->duplex = DUPLEX_FULL; > > or do you want to read the duplex from the advertisement like stated before? > > regmap_read(mpcs->regmap, SGMSYS_PCS_CONTROL_1, &bm); > regmap_read(mpcs->regmap, SGMSYS_PCS_CONTROL_1 + 8, &adv); > > phylink_mii_c22_pcs_decode_state(state, bm >> 16, adv >> 16); with the phylink-helper it works too https://github.com/frank-w/BPI-R2-4.14/commits/6.1-r3-sgmii2 regards Frank
Powered by blists - more mailing lists