netdev - Re: [PATCH net-next v8] net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210241841.RBl1cwpy-lkp@intel.com>
Date:   Mon, 24 Oct 2022 18:58:22 +0800
From:   kernel test robot <lkp@...el.com>
To:     Frank <Frank.Sae@...or-comm.com>, Peter Geis <pgwipeout@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     kbuild-all@...ts.01.org, yinghong.zhang@...or-comm.com,
        fei.zhang@...or-comm.com, hua.sun@...or-comm.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Frank <Frank.Sae@...or-comm.com>
Subject: Re: [PATCH net-next v8] net: phy: Add driver for Motorcomm yt8521
 gigabit ethernet phy

Hi Frank,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Frank/net-phy-Add-driver-for-Motorcomm-yt8521-gigabit-ethernet-phy/20221024-172915
patch link:    https://lore.kernel.org/r/20221024092820.1486-1-Frank.Sae%40motor-comm.com
patch subject: [PATCH net-next v8] net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy
config: powerpc-allyesconfig
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/5c431b5df8c16cfd6fc790a3836884d20a7ca8e4
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Frank/net-phy-Add-driver-for-Motorcomm-yt8521-gigabit-ethernet-phy/20221024-172915
        git checkout 5c431b5df8c16cfd6fc790a3836884d20a7ca8e4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/net/phy/motorcomm.c:651: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * ytphy_utp_read_lpa() read LPA then setup lp_advertising for utp


vim +651 drivers/net/phy/motorcomm.c

   649	
   650	/**
 > 651	 * ytphy_utp_read_lpa() read LPA then setup lp_advertising for utp
   652	 * @phydev: a pointer to a &struct phy_device
   653	 *
   654	 * NOTE:The caller must have taken the MDIO bus lock.
   655	 *
   656	 * returns 0 or negative errno code
   657	 */
   658	static int ytphy_utp_read_lpa(struct phy_device *phydev)
   659	{
   660		int lpa, lpagb;
   661	
   662		if (phydev->autoneg == AUTONEG_ENABLE) {
   663			if (!phydev->autoneg_complete) {
   664				mii_stat1000_mod_linkmode_lpa_t(phydev->lp_advertising,
   665								0);
   666				mii_lpa_mod_linkmode_lpa_t(phydev->lp_advertising, 0);
   667				return 0;
   668			}
   669	
   670			if (phydev->is_gigabit_capable) {
   671				lpagb = __phy_read(phydev, MII_STAT1000);
   672				if (lpagb < 0)
   673					return lpagb;
   674	
   675				if (lpagb & LPA_1000MSFAIL) {
   676					int adv = __phy_read(phydev, MII_CTRL1000);
   677	
   678					if (adv < 0)
   679						return adv;
   680	
   681					if (adv & CTL1000_ENABLE_MASTER)
   682						phydev_err(phydev, "Master/Slave resolution failed, maybe conflicting manual settings?\n");
   683					else
   684						phydev_err(phydev, "Master/Slave resolution failed\n");
   685					return -ENOLINK;
   686				}
   687	
   688				mii_stat1000_mod_linkmode_lpa_t(phydev->lp_advertising,
   689								lpagb);
   690			}
   691	
   692			lpa = __phy_read(phydev, MII_LPA);
   693			if (lpa < 0)
   694				return lpa;
   695	
   696			mii_lpa_mod_linkmode_lpa_t(phydev->lp_advertising, lpa);
   697		} else {
   698			linkmode_zero(phydev->lp_advertising);
   699		}
   700	
   701		return 0;
   702	}
   703	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (329734 bytes)