lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 24 Oct 2022 21:57:28 +0800 From: Yang Yingliang <yangyingliang@...wei.com> To: <netdev@...r.kernel.org> CC: <davem@...emloft.net>, <kuba@...nel.org> Subject: [PATCH net] net: fealnx: fix missing pci_disable_device() pci_disable_device() need be called while module exiting, switch to use pcim_enable(), pci_disable_device() and pci_release_regions() will be called in pcim_release() while unbinding device. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Yang Yingliang <yangyingliang@...wei.com> --- drivers/net/ethernet/fealnx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/fealnx.c b/drivers/net/ethernet/fealnx.c index ed18450fd2cc..fb139f295b67 100644 --- a/drivers/net/ethernet/fealnx.c +++ b/drivers/net/ethernet/fealnx.c @@ -494,7 +494,7 @@ static int fealnx_init_one(struct pci_dev *pdev, option = card_idx < MAX_UNITS ? options[card_idx] : 0; - i = pci_enable_device(pdev); + i = pcim_enable_device(pdev); if (i) return i; pci_set_master(pdev); @@ -670,7 +670,6 @@ static int fealnx_init_one(struct pci_dev *pdev, err_out_unmap: pci_iounmap(pdev, ioaddr); err_out_res: - pci_release_regions(pdev); return err; } @@ -689,7 +688,6 @@ static void fealnx_remove_one(struct pci_dev *pdev) unregister_netdev(dev); pci_iounmap(pdev, np->mem); free_netdev(dev); - pci_release_regions(pdev); } else printk(KERN_ERR "fealnx: remove for unknown device\n"); } -- 2.25.1
Powered by blists - more mailing lists