netdev - Re: [PATCH net-next 1/5] ionic: replay VF attributes after fw crash recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1aBL+jfY8uXS9Yx@unreal>
Date:   Mon, 24 Oct 2022 15:12:31 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Shannon Nelson <snelson@...sando.io>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, kuba@...nel.org,
        drivers@...sando.io
Subject: Re: [PATCH net-next 1/5] ionic: replay VF attributes after fw crash
 recovery

On Mon, Oct 24, 2022 at 03:17:13AM -0700, Shannon Nelson wrote:
> The VF attributes that the user has set into the FW through
> the PF can be lost over a FW crash recovery.  Much like we
> already replay the PF mac/vlan filters, we now add a replay
> in the recovery path to be sure the FW has the up-to-date
> VF configurations.
> 
> Signed-off-by: Shannon Nelson <snelson@...sando.io>
> ---
>  .../net/ethernet/pensando/ionic/ionic_lif.c   | 70 +++++++++++++++++++
>  1 file changed, 70 insertions(+)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> index 19d4848df17d..5d593198ad72 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> @@ -2562,6 +2562,74 @@ static int ionic_set_vf_link_state(struct net_device *netdev, int vf, int set)
>  	return ret;
>  }
>  
> +static void ionic_vf_attr_replay(struct ionic_lif *lif)
> +{
> +	struct ionic_vf_setattr_cmd vfc = { 0 };

There is no need in 0 for {} installations.

<...>

> +			(void)ionic_set_vf_config(ionic, i, &vfc);

No need to cast return type of function, it is not kernel style.

Thanks