netdev - Re: [PATCH -next] rfkill: replace BUG_ON() with WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab635939-6763-42c1-0410-79e6c65b4568@huawei.com>
Date:   Mon, 24 Oct 2022 09:58:59 +0800
From:   Yang Yingliang <yangyingliang@...wei.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <johannes@...solutions.net>
Subject: Re: [PATCH -next] rfkill: replace BUG_ON() with WARN_ON() in core.c


On 2022/10/23 16:16, Leon Romanovsky wrote:
> On Fri, Oct 21, 2022 at 09:57:38PM +0800, Yang Yingliang wrote:
>> Replace BUG_ON() with WARN_ON() to handle fault more gracefully.
>>
>> Suggested-by: Johannes Berg <johannes@...solutions.net>
>> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
>> ---
>>   net/rfkill/core.c | 25 ++++++++++++++++---------
>>   1 file changed, 16 insertions(+), 9 deletions(-)
> Please add changelog and version numbers when you set your series.
>
> The same comment as https://lore.kernel.org/all/Y1T3a1y/pWdbt2ow@unreal
The link is unreachable.
> or you should delete BUG_ONs completely or simply replace them with WARN_ONs.
>
> There is no need in all these if (...).
If remove BUG_ONs or not use if (...), it may lead null-ptr-deref, it's 
same as
using BUG_ON(), which leads system crash.

Thanks,
Yang
>
> Thanks
> .