netdev - Re: [PATCH] can: mcp251x: fix error handling code in mcp251x_can

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD-N9QWhXWNjuzf+f+bOup2GF_HRzSvRDiajdsHDKu1yke+qgg@mail.gmail.com>
Date:   Mon, 24 Oct 2022 16:43:37 +0800
From:   Dongliang Mu <mudongliangabcd@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Dongliang Mu <dzm91@...t.edu.cn>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>,
        Oliver Hartkopp <socketcan@...tkopp.net>,
        Stefan Mätje <stefan.maetje@....eu>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Sebastian Würl <sebastian.wuerl@...ratech.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] can: mcp251x: fix error handling code in mcp251x_can_probe

On Mon, Oct 24, 2022 at 4:16 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> On Mon, Oct 24, 2022 at 01:37:07PM +0800, Dongliang Mu wrote:
> > In mcp251x_can_probe, if mcp251x_gpio_setup fails, it forgets to
> > unregister the can device.
> >
> > Fix this by unregistering can device in mcp251x_can_probe.
>
> Fixes tag?

Fixes: 2d52dabbef60 ("can: mcp251x: add GPIO support")

This commit adds the mcp251x_gpio_setup function, but with an incorrect label.

>
> --
> With Best Regards,
> Andy Shevchenko
>
>