netdev - Re: [net-next 05/14] net/mlx5: DR, Allocate ste

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <057132d5-41fb-b966-3dbd-4b7dce59b305@nvidia.com>
Date:   Tue, 25 Oct 2022 13:22:38 +0300
From:   Yevgeny Kliteynik <kliteyn@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>, Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Alex Vesker <valex@...dia.com>
Subject: Re: [net-next 05/14] net/mlx5: DR, Allocate ste_arr on stack instead
 of dynamically

On 25-Oct-22 07:24, Jakub Kicinski wrote:
> On Mon, 24 Oct 2022 14:57:25 +0100 Saeed Mahameed wrote:
>> From: Yevgeny Kliteynik <kliteyn@...dia.com>
>>
>> While creting rule, ste_arr is a short array that is allocated in
>> the beginning of the function and freed at the end.
>> To avoid memory allocation "hiccups" that sometimes take up to 10ms,
>> allocate it on stack.
> 
> There's a reason, 32bit x86 does not like this:
> 
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_rule.c: In function ‘dr_rule_create_rule_nic’:
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_rule.c:1202:1: warning: the frame size of 1568 bytes is larger than 1024 bytes [-Wframe-larger-than=]
> 1202 | }
>       | ^

Thanks Jakub, indeed...
Working on v2.

-- YK