netdev - Re: [PATCH] ethtool: fix man page errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Oct 2022 16:30:48 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Xose Vazquez Perez <xose.vazquez@...il.com>
Cc:     NETDEV ML <netdev@...r.kernel.org>
Subject: Re: [PATCH] ethtool: fix man page errors

On Mon, Oct 24, 2022 at 06:39:46PM +0200, Xose Vazquez Perez wrote:
> troff: <standard input>:82: warning: macro '.' not defined
> troff: <standard input>:252: warning: macro 'RN' not defined
> troff: <standard input>:698: warning: macro 'E' not defined
> 
> Cc: Michal Kubecek <mkubecek@...e.cz>
> Cc: NETDEV ML <netdev@...r.kernel.org>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@...il.com>
> ---
> Tested with:
> man --warnings -E UTF-8 -l -Tutf8 -Z ethtool.8 > /dev/null
> groff -z -wall -b -e -t ethtool.8

These errors are not related to the patch, v6.0 gives exactly the same
result. The changes below should fix them but I'll rather double check
before submitting it, I'm not very familiar with the syntax.

Michal

-8<---
diff --git a/ethtool.8.in b/ethtool.8.in
index 1c0e2346f3a1..f34e945e271d 100644
--- a/ethtool.8.in
+++ b/ethtool.8.in
@@ -79,7 +79,6 @@
 .\"	\(*NC - Network Classifier type values
 .\"
 .ds NC \fBether\fP|\fBip4\fP|\fBtcp4\fP|\fBudp4\fP|\fBsctp4\fP|\fBah4\fP|\fBesp4\fP|\fBip6\fP|\fBtcp6\fP|\fBudp6\fP|\fBah6\fP|\fBesp6\fP|\fBsctp6\fP
-..
 .\"
 .\" Start URL.
 .de UR
@@ -249,7 +248,7 @@ ethtool \- query or control network driver and hardware settings
 .RB [\fBeth\-phy\fP]
 .RB [\fBeth\-mac\fP]
 .RB [\fBeth\-ctrl\fP]
-.RN [\fBrmon\fP]
+.RB [\fBrmon\fP]
 .RB ]
 .HP
 .B ethtool \-\-phy\-statistics
@@ -695,14 +694,13 @@ naming of NIC- and driver-specific statistics across vendors.
 .RS 4
 .TP
 .B \fB\-\-all\-groups
-.E
 .TP
 .B \fB\-\-groups [\fBeth\-phy\fP] [\fBeth\-mac\fP] [\fBeth\-ctrl\fP] [\fBrmon\fP]
 Request groups of standard device statistics.
-.RE
 .TP
 .B \-\-phy\-statistics
 Queries the specified network device for PHY specific statistics.
+.RE
 .TP
 .B \-t \-\-test
 Executes adapter selftest on the specified network device. Possible test modes are:
-8<---

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)