netdev - Re: [PATCH 1/1] net: also flag accepted sockets supporting msghdr originated zerocopy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63b0e654-5c2c-2061-44b5-3d1b2645ad19@gmail.com>
Date:   Tue, 25 Oct 2022 15:47:01 +0100
From:   Pavel Begunkov <asml.silence@...il.com>
To:     Stefan Metzmacher <metze@...ba.org>, io-uring@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     stable@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH 1/1] net: also flag accepted sockets supporting msghdr
 originated zerocopy

On 10/25/22 14:36, Stefan Metzmacher wrote:
> Without this only the client initiated tcp sockets have SOCK_SUPPORT_ZC.
> The listening socket on the server also has it, but the accepted
> connections didn't, which meant IORING_OP_SEND[MSG]_ZC will always
> fails with -EOPNOTSUPP.

Jakub pointed out a bunch of places yesterday that we have to
consider. I'll pick it up and resend with the rest. Thanks


> Fixes: e993ffe3da4b ("net: flag sockets supporting msghdr originated zerocopy")
> Cc: <stable@...r.kernel.org> # 6.0
> CC: Pavel Begunkov <asml.silence@...il.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> CC: Jens Axboe <axboe@...nel.dk>
> Link: https://lore.kernel.org/io-uring/20221024141503.22b4e251@kernel.org/T/#m38aa19b0b825758fb97860a38ad13122051f9dda
> Signed-off-by: Stefan Metzmacher <metze@...ba.org>
> ---
>   net/ipv4/af_inet.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
> index 3dd02396517d..4728087c42a5 100644
> --- a/net/ipv4/af_inet.c
> +++ b/net/ipv4/af_inet.c
> @@ -754,6 +754,8 @@ int inet_accept(struct socket *sock, struct socket *newsock, int flags,
>   		  (TCPF_ESTABLISHED | TCPF_SYN_RECV |
>   		  TCPF_CLOSE_WAIT | TCPF_CLOSE)));
>   
> +	if (test_bit(SOCK_SUPPORT_ZC, &sock->flags))
> +		set_bit(SOCK_SUPPORT_ZC, &newsock->flags);
>   	sock_graft(sk2, newsock);
>   
>   	newsock->state = SS_CONNECTED;

-- 
Pavel Begunkov