netdev - Re: [PATCH] can: mscan: mpc5xxx: fix error handling code in mpc5xxx_can

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6A916694-CA4E-4D73-8CF0-B35AC8C6B9D3@hust.edu.cn>
Date:   Tue, 25 Oct 2022 10:29:50 +0800
From:   Dongliang Mu <dzm91@...t.edu.cn>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Chris Packham <chris.packham@...iedtelesis.co.nz>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Wolfram Sang <wsa@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Cai Huoqing <cai.huoqing@...ux.dev>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Gerhard Sittig <gsi@...x.de>,
        Anatolij Gustschin <agust@...x.de>,
        Mark Brown <broonie@...nel.org>, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] can: mscan: mpc5xxx: fix error handling code in
 mpc5xxx_can_probe



> On Oct 24, 2022, at 20:00, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> 
> On Mon, Oct 24, 2022 at 07:48:07PM +0800, Dongliang Mu wrote:
>> The commit 1149108e2fbf ("can: mscan: improve clock API use
>> ") only adds put_clock in mpc5xxx_can_remove function, forgetting to add
> 
> Strange indentation. Why the '")' part can't be on the previous line?

:/ it is automatically done by vim in `git commit -a -s -e`. I can adjust this part in v2 patch.

> 
>> put_clock in the error handling code.
>> 
>> Fix this bug by adding put_clock in the error handling code.
> 
> -- 
> With Best Regards,
> Andy Shevchenko
>