netdev - Re: [V3 net 09/16] net/mlx5: SF: Fix probing active SFs during driver probe phase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221024212728.7cdd879b@kernel.org>
Date:   Mon, 24 Oct 2022 21:27:28 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Shay Drory <shayd@...dia.com>, Parav Pandit <parav@...dia.com>
Subject: Re: [V3 net 09/16] net/mlx5: SF: Fix probing active SFs during
 driver probe phase

On Mon, 24 Oct 2022 12:53:50 +0100 Saeed Mahameed wrote:
> From: Shay Drory <shayd@...dia.com>
> 
> When SF devices and SF port representors are located on different
> functions, unloading and reloading of SF parent driver doesn't recreate
> the existing SF present in the device.
> Fix it by querying SFs and probe active SFs during driver probe phase.
> 
> Fixes: 90d010b8634b ("net/mlx5: SF, Add auxiliary device support")
> Signed-off-by: Shay Drory <shayd@...dia.com>
> Reviewed-by: Parav Pandit <parav@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>

Does not build cleanly, I thought v1 built :S

drivers/net/ethernet/mellanox/mlx5/core/sf/dev/dev.c:287:6: warning: no previous prototype for function 'mlx5_sf_dev_destroy_active_work' [-Wmissing-prototypes]
void mlx5_sf_dev_destroy_active_work(struct mlx5_sf_dev_table *table)
     ^