netdev - Re: [PATCH v2] can: mcp251x: fix error handling code in mcp251x_can

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221025071551.ghj2hhcxxdfcjbcp@pengutronix.de>
Date:   Tue, 25 Oct 2022 09:15:51 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Dongliang Mu <dzm91@...t.edu.cn>
Cc:     Wolfgang Grandegger <wg@...ndegger.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>,
        Stefan Mätje <stefan.maetje@....eu>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Oliver Hartkopp <socketcan@...tkopp.net>,
        Sebastian Würl <sebastian.wuerl@...ratech.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Timo Schlüßler <schluessler@...use.de>,
        linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] can: mcp251x: fix error handling code in
 mcp251x_can_probe

On 24.10.2022 17:02:52, Dongliang Mu wrote:
> In mcp251x_can_probe, if mcp251x_gpio_setup fails, it forgets to
> unregister the can device.
> 
> Fix this by unregistering can device in mcp251x_can_probe.
> 
> Fixes: 2d52dabbef60 ("can: mcp251x: add GPIO support")
> Signed-off-by: Dongliang Mu <dzm91@...t.edu.cn>

Applied to can/main.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)