lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Oct 2022 14:40:39 +0300 From: Roi Dayan <roid@...dia.com> To: Amritha Nambiar <amritha.nambiar@...el.com>, netdev@...r.kernel.org, kuba@...nel.org Cc: alexander.duyck@...il.com, jhs@...atatu.com, jiri@...nulli.us, xiyou.wangcong@...il.com, vinicius.gomes@...el.com, sridhar.samudrala@...el.com, Maor Dickman <maord@...dia.com>, Tariq Toukan <tariqt@...dia.com>, Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>, Pablo Neira Ayuso <pablo@...filter.org> Subject: Re: [net-next PATCH v3 1/3] act_skbedit: skbedit queue mapping for receive queue > > /* Update lastuse only if needed, to avoid dirtying a cache line. > * We use a temp variable to avoid fetching jiffies twice. > diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h > index e343f9f8363e..7a60bc6d72c9 100644 > --- a/include/net/flow_offload.h > +++ b/include/net/flow_offload.h > @@ -155,6 +155,7 @@ enum flow_action_id { > FLOW_ACTION_MARK, > FLOW_ACTION_PTYPE, > FLOW_ACTION_PRIORITY, > + FLOW_ACTION_RX_QUEUE_MAPPING, > FLOW_ACTION_WAKE, > FLOW_ACTION_QUEUE, > FLOW_ACTION_SAMPLE, > @@ -247,6 +248,7 @@ struct flow_action_entry { > u32 csum_flags; /* FLOW_ACTION_CSUM */ > u32 mark; /* FLOW_ACTION_MARK */ > u16 ptype; /* FLOW_ACTION_PTYPE */ > + u16 rx_queue; /* FLOW_ACTION_RX_QUEUE_MAPPING */ > u32 priority; /* FLOW_ACTION_PRIORITY */ > struct { /* FLOW_ACTION_QUEUE */ > u32 ctx; Hi, This patch broke mlx5_core TC offloads. We have a generic code part going over the enum values and have a list of action pointers to handle parsing each action without knowing the action. The list of actions depends on being aligned with the values order of the enum which I think usually new values should go to the end of the list. I'm not sure if other code parts are broken from this change but at least one part is. New values were always inserted at the end. Can you make a fixup patch to move FLOW_ACTION_RX_QUEUE_MAPPING to the end of the enum list? i.e. right before NUM_FLOW_ACTIONS. Thanks, Roi
Powered by blists - more mailing lists