netdev - Re: [PATCH net-next v1 0/6] Various cleanups for mlx5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Oct 2022 15:27:31 +0100
From:   Saeed Mahameed <saeed@...nel.org>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
        Paolo Abeni <pabeni@...hat.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [PATCH net-next v1 0/6] Various cleanups for mlx5

On 25 Oct 14:25, Leon Romanovsky wrote:
>On Tue, Oct 25, 2022 at 12:00:11PM +0100, Saeed Mahameed wrote:
>> On 24 Oct 19:59, Leon Romanovsky wrote:
>> > From: Leon Romanovsky <leonro@...dia.com>
>> >
>> > Changelog:
>> > v1:
>> > Patch #1:
>> > * Removed extra blank line
>> > * Removed ipsec initialization for uplink
>>
>> This will break functionality, ipsec should only be enabled on nic and
>> uplink but not on other vport representors.
>
>I didn't hear any complain from verification. The devlink patch is in
>my tree for months already.
>

the regression is clear in the code. Ask Raed he added the functionality
for uplink.

>>
>> Leon let's finish review internally, this series has to go through my trees
>> anyways.
>
>What about other 5 patches? Let's progress with them, please.
>

Sure, I will take other patches into my tree, but please let's do internal
reviews next time, no need to clutter ML with mlx5 specific stuff.