netdev - Re: [PATCH] ipvs: use explicitly signed chars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb93406f-6935-deee-22e4-c4b4be55bc60@ssi.bg>
Date:   Wed, 26 Oct 2022 18:01:09 +0300 (EEST)
From:   Julian Anastasov <ja@....bg>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
cc:     netdev@...r.kernel.org, lvs-devel@...r.kernel.org,
        netfilter-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Simon Horman <horms@...ge.net.au>, stable@...r.kernel.org
Subject: Re: [PATCH] ipvs: use explicitly signed chars


	Hello,

On Wed, 26 Oct 2022, Jason A. Donenfeld wrote:

> On Wed, Oct 26, 2022 at 05:20:03PM +0300, Julian Anastasov wrote:
> > 
> > 	Hello,
> > 
> > On Wed, 26 Oct 2022, Jason A. Donenfeld wrote:
> > 
> > > The `char` type with no explicit sign is sometimes signed and sometimes
> > > unsigned. This code will break on platforms such as arm, where char is
> > > unsigned. So mark it here as explicitly signed, so that the
> > > todrop_counter decrement and subsequent comparison is correct.
> > > 
> > > Cc: Pablo Neira Ayuso <pablo@...filter.org>
> > > Cc: Julian Anastasov <ja@....bg>
> > > Cc: Simon Horman <horms@...ge.net.au>
> > > Cc: stable@...r.kernel.org
> > > Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> > 
> > 	Looks good to me for -next, thanks!
> 
> This is actually net.git material, not net-next.git material,
> considering it fixes a bug on arm and many other archs, and is marked
> with a stable@ tag.

	OK. As algorithm is not SMP safe, the problem is
not just for the first 256 packets on these platforms.

Regards

--
Julian Anastasov <ja@....bg>