netdev - Re: [PATCH net-next] netlink: split up copies in the ack construction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202210261634.9DA43B2F@keescook>
Date:   Wed, 26 Oct 2022 16:35:09 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com
Subject: Re: [PATCH net-next] netlink: split up copies in the ack construction

On Wed, Oct 26, 2022 at 02:04:30PM -0700, Jakub Kicinski wrote:
> Clean up the use of unsafe_memcpy() by adding a flexible array
> at the end of netlink message header and splitting up the header
> and data copies.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Looks good to me. Thanks for this refactoring. :)

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook