lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20221027025726.2138619-1-liuhangbin@gmail.com> Date: Thu, 27 Oct 2022 10:57:22 +0800 From: Hangbin Liu <liuhangbin@...il.com> To: netdev@...r.kernel.org Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Ido Schimmel <idosch@...dia.com>, Petr Machata <petrm@...dia.com>, Florent Fourcot <florent.fourcot@...irst.fr>, Nikolay Aleksandrov <razor@...ckwall.org>, Nicolas Dichtel <nicolas.dichtel@...nd.com>, Guillaume Nault <gnault@...hat.com>, David Ahern <dsahern@...nel.org>, Hangbin Liu <liuhangbin@...il.com> Subject: [PATCHv6 net-next 0/4] rtnetlink: Honour NLM_F_ECHO flag in rtnl_{new, del}link Netlink messages are used for communicating between user and kernel space. When user space configures the kernel with netlink messages, it can set the NLM_F_ECHO flag to request the kernel to send the applied configuration back to the caller. This allows user space to retrieve configuration information that are filled by the kernel (either because these parameters can only be set by the kernel or because user space let the kernel choose a default value). The kernel has support this feature in some places like RTM_{NEW, DEL}ADDR, RTM_{NEW, DEL}ROUTE. This patch set handles NLM_F_ECHO flag and send link info back after rtnl_{new, del}link. v6: 1) Rename pid to portid, make all nlh const 2) Re-order the portid, nlh parameter for each function 3) Do not add rtnl_configure_link_notify() warpper as Guillaume suggested. Just modify rtnl_configure_link() directly in patch 01. Also remove the rtmsg_ifinfo_nlh() wrapper. 4) Un-export unregister_netdevice_many_notify() in patch 02 v5: 1) Make rtnl_configure_link_notify static, reported by kernel test robot v4: 1) Add rtnl_configure_link_notify() helper so rtnl_newlink_create could use it instead of creating new notify function. 2) Add unregister_netdevice_many_notify() helper so rtnl_delete_link() could use it instead of creating new notify function 3) Split the previous patch to 4 small patches for easier reviewing. v3: 1) Fix group parameter in rtnl_notify. 2) Use helper rtmsg_ifinfo_build_skb() instead re-write a new one. v2: 1) Rename rtnl_echo_link_info() to rtnl_link_notify(). 2) Remove IFLA_LINK_NETNSID and IFLA_EXT_MASK, which do not fit here. 3) Add NLM_F_ECHO in rtnl_dellink. But we can't re-use the rtnl_link_notify() helper as we need to get the link info before rtnl_delete_link(). Hangbin Liu (4): rtnetlink: pass netlink message header and portid to rtnl_configure_link() net: add new helper unregister_netdevice_many_notify rtnetlink: Honour NLM_F_ECHO flag in rtnl_newlink_create rtnetlink: Honour NLM_F_ECHO flag in rtnl_delete_link drivers/net/can/vxcan.c | 2 +- drivers/net/geneve.c | 2 +- drivers/net/veth.c | 2 +- drivers/net/vxlan/vxlan_core.c | 4 +-- drivers/net/wwan/wwan_core.c | 2 +- include/linux/netdevice.h | 2 -- include/linux/rtnetlink.h | 9 ++++--- include/net/netlink.h | 11 ++++++++ include/net/rtnetlink.h | 5 ++-- net/core/dev.c | 36 ++++++++++++++++---------- net/core/dev.h | 7 ++++++ net/core/rtnetlink.c | 46 +++++++++++++++++++--------------- net/ipv4/ip_gre.c | 2 +- net/openvswitch/vport-geneve.c | 2 +- net/openvswitch/vport-gre.c | 2 +- net/openvswitch/vport-netdev.c | 2 +- net/openvswitch/vport-vxlan.c | 2 +- 17 files changed, 86 insertions(+), 52 deletions(-) -- 2.37.3
Powered by blists - more mailing lists