netdev - Re: [PATCH net-next 1/2] net: sfp: convert register indexes from hex to decimal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1qY+nwr4SzmyhhD@lunn.ch>
Date:   Thu, 27 Oct 2022 16:43:06 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net: sfp: convert register indexes from hex
 to decimal

On Thu, Oct 27, 2022 at 02:21:16PM +0100, Russell King (Oracle) wrote:
> The register indexes in the standards are in decimal rather than hex,
> so lets specify them in decimal in the header file so we can easily
> cross-reference without converting between hex and decimal.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Makes sense, but i've not checked for typos. Did you see if the
generated code remains identical?

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew