netdev - Re: [PATCH] net: broadcom: bcm4908_enet: update TX stats after actual transmission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf8c3805-4688-bacc-bdc5-76ea990e7928@gmail.com>
Date:   Thu, 27 Oct 2022 18:30:26 +0200
From:   Rafał Miłecki <zajec5@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com,
        Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH] net: broadcom: bcm4908_enet: update TX stats after actual
 transmission

On 27.10.2022 18:12, Florian Fainelli wrote:
> On 10/27/2022 4:24 AM, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@...ecki.pl>
>>
>> Queueing packets doesn't guarantee their transmission. Update TX stats
>> after hardware confirms consuming submitted data.
>>
>> This also fixes a possible race and NULL dereference.
>> bcm4908_enet_start_xmit() could try to access skb after freeing it in
>> the bcm4908_enet_poll_tx().
>>
>> Reported-by: Florian Fainelli <f.fainelli@...il.com>
>> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
> 
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> 
> To me this is 'net' material since it fixes a potential issue, but let's see what the netdev maintainers prefer.

Thanks. In that case it may be also worth adding:

Fixes: 4feffeadbcb2e ("net: broadcom: bcm4908enet: add BCM4908 controller driver")