netdev - Re: [net-next] phy: convert to boolean for the mac_managed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Oct 2022 23:09:52 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Denis Kirjanov <dkirjanov@...e.de>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Joakim Zhang <qiangqing.zhang@....com>
Subject: Re: [net-next] phy: convert to boolean for the mac_managed_pm flag

On 27.10.2022 17:05, Denis Kirjanov wrote:
> Signed-off-by: Dennis Kirjanov <dkirjanov@...e.de>

Commit message is missing.
It should be "net: phy:" instead of "phy:".
You state that you convert the flag to boolean but you convert only the users.

> ---
>  drivers/net/ethernet/freescale/fec_main.c | 2 +-
>  drivers/net/ethernet/realtek/r8169_main.c | 2 +-
>  drivers/net/usb/asix_devices.c            | 4 ++--

This should be separate patches.

>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index 98d5cd313fdd..4d38a297ec00 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2226,7 +2226,7 @@ static int fec_enet_mii_probe(struct net_device *ndev)
>  	fep->link = 0;
>  	fep->full_duplex = 0;
>  
> -	phy_dev->mac_managed_pm = 1;
> +	phy_dev->mac_managed_pm = true;
>  
Definition is: unsigned mac_managed_pm:1;
Therefore 1 is the correct value, why assigning a bool to a bitfield member?

>  	phy_attached_info(phy_dev);
>  
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index a73d061d9fcb..5bc1181f829b 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -5018,7 +5018,7 @@ static int r8169_mdio_register(struct rtl8169_private *tp)
>  		return -EUNATCH;
>  	}
>  
> -	tp->phydev->mac_managed_pm = 1;
> +	tp->phydev->mac_managed_pm = true;
>  
>  	phy_support_asym_pause(tp->phydev);
>  
> diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
> index 11f60d32be82..02941d97d034 100644
> --- a/drivers/net/usb/asix_devices.c
> +++ b/drivers/net/usb/asix_devices.c
> @@ -700,7 +700,7 @@ static int ax88772_init_phy(struct usbnet *dev)
>  	}
>  
>  	phy_suspend(priv->phydev);
> -	priv->phydev->mac_managed_pm = 1;
> +	priv->phydev->mac_managed_pm = true;
>  
>  	phy_attached_info(priv->phydev);
>  
> @@ -720,7 +720,7 @@ static int ax88772_init_phy(struct usbnet *dev)
>  		return -ENODEV;
>  	}
>  
> -	priv->phydev_int->mac_managed_pm = 1;
> +	priv->phydev_int->mac_managed_pm = true;
>  	phy_suspend(priv->phydev_int);
>  
>  	return 0;