netdev - Re: [PATCH v5 net-next] net: ftmac100: support mtu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABikg9yjX1Zypr4pwp8jgZZsUiNxW1m271RonGK2ojuYjYHJ2A@mail.gmail.com>
Date:   Fri, 28 Oct 2022 18:21:46 +0300
From:   Sergei Antonov <saproj@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     netdev@...r.kernel.org, andrew@...n.ch, pabeni@...hat.com,
        kuba@...nel.org, edumazet@...gle.com, davem@...emloft.net
Subject: Re: [PATCH v5 net-next] net: ftmac100: support mtu > 1500

On Thu, 27 Oct 2022 at 21:54, Vladimir Oltean <olteanv@...il.com> wrote:
>
> On Thu, Oct 27, 2022 at 07:59:11PM +0300, Sergei Antonov wrote:
> > On Thu, 27 Oct 2022 at 14:35, Vladimir Oltean <olteanv@...il.com> wrote:
> > > Does the attached series of 3 patches work for you? I only compile
> > > tested them.
> >
> > I have tested your patches. They fix the problem I have. If they can
> > make it into mainline Linux - great. Thanks for your help!
>
> Do you mind submitting these patches yourself, to get a better
> understanding of the process? You only need to make sure that you
> preserve the "From:" field (the authorship), and that below the existing
> Signed-off-by line, you also add yours (to make it clear that the
> patches authored by me were not submitted by me). Like this:
>
> | From: Vladimir Oltean <vladimir.oltean@....com>
> |
> | bla bla
> |
> | Signed-off-by: Vladimir Oltean <vladimir.oltean@....com> <- same as author
> | Signed-off-by: Sergei Antonov <saproj@...il.com> <- patch carried by X
> | ...etc
> | when patch is merged, the netdev maintainer adds his own sign off at
> | the end to indicate that the patch went through his own hands
>
> I would do the same if I was the one submitting the series; I would add
> my sign-off to patch 3/3, which has your authorship.

OK. I will do it.

> > A remark on 0002-net-ftmac100-report-the-correct-maximum-MTU-of-1500.patch:
> > I can not make a case for VLAN_ETH_HLEN because it includes 4 bytes
> > from a switch and ftmac100 is not always used with a switch.
>
> Why do you think that? What VLAN are you talking about? 802.1Q or
> 802.1ad? What VLAN ID? Where does it come from, where do you see it?

Patch 2 contains this change:
-       netdev->max_mtu = MAX_PKT_SIZE;
+       netdev->max_mtu = MAX_PKT_SIZE - VLAN_ETH_HLEN;

VLAN_ETH_HLEN is equal to 18 which is 6+6+4+2
It includes 4 bytes of 802.1Q.

> VLAN_ETH_HLEN in patch 2 has nothing to do with a switch.

OK then.