netdev - Re: [PATCH v3 net-next] net: dsa: mv88e6xxx: Add RGMII delay to 88E6320

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1wi6t4Cu0R7qFxp@lunn.ch>
Date:   Fri, 28 Oct 2022 20:43:54 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Fabio Estevam <festevam@...il.com>
Cc:     kuba@...nel.org, davem@...emloft.net, olteanv@...il.com,
        netdev@...r.kernel.org,
        Steffen Bätz <steffen@...osonix.de>,
        Fabio Estevam <festevam@...x.de>
Subject: Re: [PATCH v3 net-next] net: dsa: mv88e6xxx: Add RGMII delay to
 88E6320

On Fri, Oct 28, 2022 at 01:31:58PM -0300, Fabio Estevam wrote:
> From: Steffen Bätz <steffen@...osonix.de>
> 
> Currently, the .port_set_rgmii_delay hook is missing for the 88E6320
> family, which causes failure to retrieve an IP address via DHCP.
> 
> Add mv88e6320_port_set_rgmii_delay() that allows applying the RGMII
> delay for ports 2, 5, and 6, which are the only ports that can be used
> in RGMII mode.
> 
> Tested on a custom i.MX8MN board connected to an 88E6320 switch.
> 
> This change also applies safely to the 88E6321 variant.
> 
> The only difference between 88E6320 versus 88E6321 is the temperature
> grade and pinout.
> 
> They share exactly the same MDIO register map for ports 2, 5, and 6,
> which are the only ports that can be used in RGMII mode.
> 
> Signed-off-by: Steffen Bätz <steffen@...osonix.de>
> [fabio: Improved commit log and extended it to mv88e6321_ops]
> Signed-off-by: Fabio Estevam <festevam@...x.de>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew