lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 28 Oct 2022 11:16:41 +0800
From:   kernel test robot <yujie.liu@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <oe-lkp@...ts.linux.dev>, <lkp@...el.com>,
        <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <pabeni@...hat.com>,
        <jacob.e.keller@...el.com>, <johannes@...solutions.net>,
        Jakub Kicinski <kuba@...nel.org>, <jiri@...dia.com>
Subject: Re: [PATCH net] genetlink: limit the use of validation workarounds
 to old ops

Hi Jakub,

Thanks for your patch. We noticed that a new warning was added, and it
is triggered in our boot test. Please kindly check the details below to
see if it is the expected result. Thanks.


Greeting,

FYI, we noticed WARNING:at_net/netlink/genetlink.c:#genl_register_family due to commit (built with gcc-11):

commit: 053ccbb069d20f18a971789402f56a3d93b7813a ("[PATCH net] genetlink: limit the use of validation workarounds to old ops")
url: https://github.com/intel-lab-lkp/linux/commits/Jakub-Kicinski/genetlink-limit-the-use-of-validation-workarounds-to-old-ops/20221026-081700
base: https://git.kernel.org/cgit/linux/kernel/git/davem/net.git 3b32c9932853e11d71f9db012d69e92e4669ba23
patch link: https://lore.kernel.org/netdev/20221026001524.1892202-1-kuba@kernel.org
patch subject: [PATCH net] genetlink: limit the use of validation workarounds to old ops

in testcase: boot

on test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G

caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):


[    6.496103][    T1] ------------[ cut here ]------------
[ 6.496744][ T1] WARNING: CPU: 0 PID: 1 at net/netlink/genetlink.c:383 genl_register_family (??:?) 
[    6.497945][    T1] Modules linked in:
[    6.498395][    T1] CPU: 0 PID: 1 Comm: swapper Tainted: G        W          6.1.0-rc2-00078-g053ccbb069d2 #1 f1f470ea57d8c95684c9448fa68e7283b0f2272e
[ 6.499963][ T1] EIP: genl_register_family (??:?) 
[ 6.500597][ T1] Code: 0f 0b 8b 45 c0 85 c0 0f 84 ef 01 00 00 0f b6 45 d0 8b 75 ac 88 45 b3 3a 46 28 0f 82 44 01 00 00 80 7d d3 00 0f 84 3a 01 00 00 <0f> 0b be ea ff ff ff 8b 45 f0 2b 05 f0 d0 70 c3 0f 85 7b 02 00 00
All code
========
   0:	0f 0b                	ud2    
   2:	8b 45 c0             	mov    -0x40(%rbp),%eax
   5:	85 c0                	test   %eax,%eax
   7:	0f 84 ef 01 00 00    	je     0x1fc
   d:	0f b6 45 d0          	movzbl -0x30(%rbp),%eax
  11:	8b 75 ac             	mov    -0x54(%rbp),%esi
  14:	88 45 b3             	mov    %al,-0x4d(%rbp)
  17:	3a 46 28             	cmp    0x28(%rsi),%al
  1a:	0f 82 44 01 00 00    	jb     0x164
  20:	80 7d d3 00          	cmpb   $0x0,-0x2d(%rbp)
  24:	0f 84 3a 01 00 00    	je     0x164
  2a:*	0f 0b                	ud2    		<-- trapping instruction
  2c:	be ea ff ff ff       	mov    $0xffffffea,%esi
  31:	8b 45 f0             	mov    -0x10(%rbp),%eax
  34:	2b 05 f0 d0 70 c3    	sub    -0x3c8f2f10(%rip),%eax        # 0xffffffffc370d12a
  3a:	0f 85 7b 02 00 00    	jne    0x2bb

Code starting with the faulting instruction
===========================================
   0:	0f 0b                	ud2    
   2:	be ea ff ff ff       	mov    $0xffffffea,%esi
   7:	8b 45 f0             	mov    -0x10(%rbp),%eax
   a:	2b 05 f0 d0 70 c3    	sub    -0x3c8f2f10(%rip),%eax        # 0xffffffffc370d100
  10:	0f 85 7b 02 00 00    	jne    0x291
[    6.502909][    T1] EAX: 00000001 EBX: 00000000 ECX: c29f8780 EDX: c29f87c0
[    6.503731][    T1] ESI: c2ea7620 EDI: 00000004 EBP: c0243f0c ESP: c0243eb0
[    6.504545][    T1] DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068 EFLAGS: 00010206
[    6.505451][    T1] CR0: 80050033 CR2: ffdda000 CR3: 03ec8000 CR4: 00040690
[    6.506379][    T1] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
[    6.507183][    T1] DR6: fffe0ff0 DR7: 00000400
[    6.507728][    T1] Call Trace:
[ 6.508118][ T1] ? ovs_flow_cmd_get (datapath.c:?) 
[ 6.508707][ T1] dp_init (datapath.c:?) 
[ 6.509154][ T1] ? batadv_tt_cache_init (datapath.c:?) 
[ 6.509859][ T1] do_one_initcall (??:?) 
[ 6.510402][ T1] ? rdinit_setup (main.c:?) 
[ 6.510948][ T1] do_initcalls (main.c:?) 
[ 6.511459][ T1] kernel_init_freeable (main.c:?) 
[ 6.512066][ T1] ? rest_init (main.c:?) 
[ 6.512579][ T1] kernel_init (main.c:?) 
[ 6.513077][ T1] ret_from_fork (??:?) 
[    6.513754][    T1] irq event stamp: 1616983
[ 6.514266][ T1] hardirqs last enabled at (1616991): __up_console_sem (printk.c:?) 
[ 6.515287][ T1] hardirqs last disabled at (1616998): __up_console_sem (printk.c:?) 
[ 6.516304][ T1] softirqs last enabled at (1616838): __do_softirq (??:?) 
[ 6.517335][ T1] softirqs last disabled at (1616829): call_on_stack (irq_32.c:?) 
[    6.518460][    T1] ---[ end trace 0000000000000000 ]---
[ 6.519498][ T1] initcall dp_init+0x0/0x111 returned -22 after 24574 usecs 
[ 6.520358][ T1] calling vsock_init+0x0/0xed @ 1 
[    6.521305][    T1] NET: Registered PF_VSOCK protocol family
[ 6.522084][ T1] initcall vsock_init+0x0/0xed returned 0 after 1149 usecs 


If you fix the issue, kindly add following tag
| Reported-by: kernel test robot <yujie.liu@...el.com>
| Link: https://lore.kernel.org/oe-lkp/202210280959.af691299-yujie.liu@intel.com


To reproduce:

        # build kernel
	cd linux
	cp config-6.1.0-rc2-00078-g053ccbb069d2 .config
	make HOSTCC=gcc-11 CC=gcc-11 ARCH=i386 olddefconfig prepare modules_prepare bzImage modules
	make HOSTCC=gcc-11 CC=gcc-11 ARCH=i386 INSTALL_MOD_PATH=<mod-install-dir> modules_install
	cd <mod-install-dir>
	find lib/ | cpio -o -H newc --quiet | gzip > modules.cgz


        git clone https://github.com/intel/lkp-tests.git
        cd lkp-tests
        bin/lkp qemu -k <bzImage> -m modules.cgz job-script # job-script is attached in this email

        # if come across any failure that blocks the test,
        # please remove ~/.lkp and /lkp dir to run from a clean state.


-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config-6.1.0-rc2-00078-g053ccbb069d2" of type "text/plain" (153225 bytes)

View attachment "job-script" of type "text/plain" (4989 bytes)

Download attachment "dmesg.xz" of type "application/x-xz" (47824 bytes)

Powered by blists - more mailing lists