lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 Oct 2022 10:15:19 +0200 From: Leon Romanovsky <leon@...nel.org> To: Sabrina Dubroca <sd@...asysnail.net> Cc: netdev@...r.kernel.org, Antoine Tenart <atenart@...nel.org> Subject: Re: [PATCH net v2 4/5] macsec: fix detection of RXSCs when toggling offloading On Wed, Oct 26, 2022 at 11:56:26PM +0200, Sabrina Dubroca wrote: > macsec_is_configured incorrectly uses secy->n_rx_sc to check if some > RXSCs exist. secy->n_rx_sc only counts the number of active RXSCs, but > there can also be inactive SCs as well, which may be stored in the > driver (in case we're disabling offloading), or would have to be > pushed to the device (in case we're trying to enable offloading). > > As long as RXSCs active on creation and never turned off, the issue is > not visible. > > Fixes: dcb780fb2795 ("net: macsec: add nla support for changing the offloading selection") > Signed-off-by: Sabrina Dubroca <sd@...asysnail.net> > --- > drivers/net/macsec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@...dia.com>
Powered by blists - more mailing lists