lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 Oct 2022 11:11:23 +0100 From: Paul Menzel <pmenzel@...gen.mpg.de> To: Kang Minchul <tegongkang@...il.com> Cc: Marcel Holtmann <marcel@...tmann.org>, Johan Hedberg <johan.hedberg@...il.com>, Luiz Augusto von Dentz <luiz.dentz@...il.com>, "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] Bluetooth: Use kzalloc instead of kmalloc/memset Dear Kang, Thank you for the patch. Am 29.10.22 um 23:40 schrieb Kang Minchul: > This commit replace kmalloc + memset to kzalloc replace*s* (Though starting with “This commit …” is redundant. > for better code readability and simplicity. > > Following messages are related cocci warnings. Maybe: This addresse the cocci warning below. > WARNING: kzalloc should be used for d, instead of kmalloc/memset > > Signed-off-by: Kang Minchul <tegongkang@...il.com> > --- > V1 -> V2: Change subject prefix > > net/bluetooth/hci_conn.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c > index 7a59c4487050..287d313aa312 100644 > --- a/net/bluetooth/hci_conn.c > +++ b/net/bluetooth/hci_conn.c > @@ -824,11 +824,10 @@ static int hci_le_terminate_big(struct hci_dev *hdev, u8 big, u8 bis) > > bt_dev_dbg(hdev, "big 0x%2.2x bis 0x%2.2x", big, bis); > > - d = kmalloc(sizeof(*d), GFP_KERNEL); > + d = kzalloc(sizeof(*d), GFP_KERNEL); > if (!d) > return -ENOMEM; > > - memset(d, 0, sizeof(*d)); > d->big = big; > d->bis = bis; > > @@ -861,11 +860,10 @@ static int hci_le_big_terminate(struct hci_dev *hdev, u8 big, u16 sync_handle) > > bt_dev_dbg(hdev, "big 0x%2.2x sync_handle 0x%4.4x", big, sync_handle); > > - d = kmalloc(sizeof(*d), GFP_KERNEL); > + d = kzalloc(sizeof(*d), GFP_KERNEL); > if (!d) > return -ENOMEM; > > - memset(d, 0, sizeof(*d)); > d->big = big; > d->sync_handle = sync_handle; Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de> Kind regards, Paul
Powered by blists - more mailing lists