lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 Oct 2022 22:22:25 +0100 From: Andrew Lunn <andrew@...n.ch> To: Vladimir Oltean <vladimir.oltean@....com> Cc: Michael Walle <michael@...le.cc>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Heiko Thiery <heiko.thiery@...il.com> Subject: Re: [RFC PATCH net-next 0/3] Autoload DSA tagging driver when dynamically changing protocol On Fri, Oct 28, 2022 at 09:28:41AM +0000, Vladimir Oltean wrote: > On Fri, Oct 28, 2022 at 11:17:40AM +0200, Michael Walle wrote: > > > alias: dsa_tag-ocelot-8021q > > > alias: dsa_tag-20 > > > > I know that name clashes are not to be expected because one is a numerical id > > and the other is a string, but it might still make sense to have a different > > prefix so the user of modinfo can figure that out more easily. > > > > Presuming that backwards compatibility is not an issue, maybe: > > dsa_tag-ocelot-8021q > > dsa_tag-id-20 > > Hm, it probably isn't an issue, but I'd like to hear from > Andrew/Florian/Vivien as well? I don't see it being a big issue either way. This is not ABI, as Vladimir points out. These module strings are also somewhat black magic: pci:v00001269d000000BBsv*sd*bc*sc*i* usb:v17E9p*d*dc*dsc*dp*icFFisc00ip00in* virtio:d00000005v* pcmcia:m*c*f02fn*pfn*pa*pb*pc*pd* acpi*:TPF0001:* I don't think they are meant to be human readable. I do however wounder if they should be dsa_tag:ocelot-8021q, dsa_tag:20 ? Andrew
Powered by blists - more mailing lists