| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 31 Oct 2022 10:25:14 -0400
From: drake@...ketalley.com
To: Manish Chopra <manishc@...vell.com>, GR-Linux-NIC-Dev@...vell.com,
Coiby Xu <coiby.xu@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
netdev@...r.kernel.org, linux-staging@...ts.linux.dev
Cc: linux-kernel@...r.kernel.org, Drake Talley <drake@...ketalley.com>
Subject: [PATCH 1/3] staging: qlge: Separate multiple assignments
From: Drake Talley <drake@...ketalley.com>
Adhere to coding style.
Reported by checkpatch:
> CHECK: multiple assignments should be avoided
> #4088: FILE: drivers/staging/qlge/qlge_main.c:4088
> CHECK: multiple assignments should be avoided
> #4108: FILE: drivers/staging/qlge/qlge_main.c:4108:
Signed-off-by: Drake Talley <drake@...ketalley.com>
---
drivers/staging/qlge/qlge_main.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index 1ead7793062a..8c1fdd8ebba0 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -4085,7 +4085,12 @@ static struct net_device_stats *qlge_get_stats(struct net_device
int i;
/* Get RX stats. */
- pkts = mcast = dropped = errors = bytes = 0;
+ pkts = 0;
+ mcast = 0;
+ dropped = 0;
+ errors = 0;
+ bytes = 0;
+
for (i = 0; i < qdev->rss_ring_count; i++, rx_ring++) {
pkts += rx_ring->rx_packets;
bytes += rx_ring->rx_bytes;
@@ -4100,7 +4105,10 @@ static struct net_device_stats *qlge_get_stats(struct net_device
ndev->stats.multicast = mcast;
/* Get TX stats. */
- pkts = errors = bytes = 0;
+ pkts = 0;
+ errors = 0;
+ bytes = 0;
+
for (i = 0; i < qdev->tx_ring_count; i++, tx_ring++) {
pkts += tx_ring->tx_packets;
bytes += tx_ring->tx_bytes;
--
2.34.1
Powered by blists - more mailing lists