lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 31 Oct 2022 16:54:48 +0100
From:   Jiri Benc <>
To:     Jakub Kicinski <>
Cc:, Shmulik Ladkani <>,
        Eric Dumazet <>,
        Tomas Hruby <>,
        Jeremi Piotrowski <>,,,
        Paolo Abeni <>
Subject: Re: [PATCH net] net: gso: fix panic on frag_list with mixed head
 alloc types

On Fri, 28 Oct 2022 21:41:23 -0700, Jakub Kicinski wrote:
> On Thu, 27 Oct 2022 10:20:56 +0200 Jiri Benc wrote:
> > It turns out this assumption does not hold. We've seen BUG_ON being hit
> > in skb_segment when skbs on the frag_list had differing head_frag. That
> > particular case was with vmxnet3; looking at the driver, it indeed uses
> > different skb allocation strategies based on the packet size.  
> Where are you looking? I'm not seeing it TBH.

Looking at the code again, I think I misread it.

> I don't think the driver is that important, tho, __napi_alloc_skb() 
> will select page backing or kmalloc, all by itself.

In this case, it was __netdev_alloc_skb. I'll fix the description.



Powered by blists - more mailing lists