lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 31 Oct 2022 10:17:27 +0800 From: Cai Huoqing <cai.huoqing@...ux.dev> To: Jakub Kicinski <kuba@...nel.org> Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Zhengchao Shao <shaozhengchao@...wei.com>, Bin Chen <bin.chen@...igine.com>, Alexei Starovoitov <ast@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable On 27 10月 22 11:02:41, Jakub Kicinski wrote: > On Wed, 26 Oct 2022 20:59:10 +0800 Cai Huoqing wrote: > > Subject: [PATCH 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable > > Please put [PATCH net-next] or [PATCH -next] in the subject, > to make the patch sorting easier for maintainers. > > > The print cmd code is in hex, so using hex cmd code intead of > > decimal is easy to check the value with print info. > > > - HINIC_PORT_CMD_SET_AUTONEG = 219, > > - > > - HINIC_PORT_CMD_GET_STD_SFP_INFO = 240, > > - > > - HINIC_PORT_CMD_SET_LRO_TIMER = 244, > > - > > - HINIC_PORT_CMD_SET_VF_MAX_MIN_RATE = 249, > > - > > - HINIC_PORT_CMD_GET_SFP_ABS = 251, > > + HINIC_PORT_CMD_GET_SFP_ABS = 0xFB, > > This deletes some entries. Please don't mix changes with mechanical > conversions. After checking my patch again, these can be find, + HINIC_PORT_CMD_SET_AUTONEG = 0xDB, + HINIC_PORT_CMD_GET_STD_SFP_INFO = 0xF0, + HINIC_PORT_CMD_SET_LRO_TIMER = 0xF4, + HINIC_PORT_CMD_SET_VF_MAX_MIN_RATE = 0xF9,
Powered by blists - more mailing lists